-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more GNU/Linux distros, desktop environments and window managers #93
Conversation
- ArcoLinux - BigLinux - Crystal Linux - Garuda Linux - GNOME (DE) - Hyperbola GNU/Linux-libre - LXLE Linux - Parabola GNU/Linux-libre - Puppy Linux - Trisquel GNU/Linux
- Awesome WM - BSPWM - dwm - Enlightenment - Fluxbox - i3 - JWM - Qtile - Sway
- KDE neon - KDE Plasma - Kubuntu
- Include instruction to insert Unicode glyph using the keyboard - Fix the markdown table format
With the new commit also #78 and #88 are addressed. About KDE logos I take the files from Aura's branch, since there were a lot of conflicts I didn't merge her branch. New logos:
|
Using their recently updated logo, based on MEPIS.
LGTM |
In case someone want to test the new logos here is an unofficial release that I use, it can change depending on what is merged into main. |
- Archcraft & XeroLinux and popular Arch based distros - Tails & Qubes OS are secure OS's - Loc-OS Linux is a lightweight distro, popular in Latin America
- Lemmy - PeerTube - Pleroma - Pixelfed - Fediverse
- Deluge - Forgejo - Gitea - Librewolf - Thunderbird - Tor browser
- Arduino - F-droid - FOSDEM - OSH - OSHWA - OSI - RepRap - WikiMedia
- VS Codium - FreeCAD - freedesktop.org - GIMP - GTK - Inkscape - Jellyfin - Kdenlive - KiCad - MariaDB - mpv - NextCloud - OpemCV - OpenMediaVault
Hej @hasecilu I would like to comment several things: 1
I'm not sure if this is a question or something unexpected or just states that it did convert correctly? 2You add a lot icons here, and even shout out on gitter for ideas for even more icons. In contrast I would only relevant icons (for some definition of 'relevant'). We do not need to reflect any and all (even short lived) projects out there. For example I have never heard of 'peertube'. Yes, it is around for 5 years, yes it is open source, ... but is it really needed in font-logos? It's not that it is a machine-logo people put into their shells, it's not a file type. Not that I have anything against peertube. I really want to caution against adding icons in a frenzy. There was a bit of a stop after 1.0.1, but that does not mean we need to double the number of icons in just one PR and with version step. Previously icons were added after careful consideration. 3The amount of icons in one PR becomes unmanageable here. We can not even start talking about the icons that are already there because more are added along the way. Ideally I would expect for each icon
4The amount of codepoints is limited, at least if you consider font-logos' inclusion into Nerd Fonts. The slot allocated to font-logos is If we ignore Nerd Fonts, it might still be a problem as there might be people out there who want to use font-logos but have limited resources and a multi-megabyte font file is not an option. If included in websites it will lag them down. This is often not a consideration for web usage nowadays, otoh people invented mechanisms to reduce bandwidth for embedded font downloads, so in general it is still a problem. ConclusionI believe less is more and instead we should put more energy into the fewer icons that are really added. (*) Different rendering engines have unfortunately different idiosyncrasies. Some allow overlapping paths, some dont. Some can/do use the direction of the path to define addition or subtraction. Some can not render acute angles very well and you would need to make them obtuse manually. All these problems do not occur in SVG, but they are existing in ttf/otf. |
Hmm, what is that? Spurious points? Is this icon simplified icon (concept wise), all the small dots (looks like dirt), maybe they have a more simple one? Unusable thin? Also rather thin, not useful at small sizes probably. Maybe use a solid instead of a hollow variant? Circles around the X are very very thin? Gap between the X legs probably too small? Looks like a icon intended to be displayed very big. Very hard to see ;-) I can help iron out problems, but the ever increasing mass here is a motivational challenge. Edit: This is what I meant by solid instead of hollow: |
+1 on being a bit more restrictive with adding icons. We have no way of tracking their usage after they're released, so I'd prefer we add icons because they're needed and requested, not just because we can. Asking for icon ideas is a clear indication that it's done for the latter reason, although the effort is commendable. |
Lets see which icons we have in the PR right now...:
|
What I was saying is that I converted the strokes to paths using the
Yeah, this branch ended up being more a testing branch than ready to merge. Considering the use cases Linux distros, web apps and desktop apps we can ask fr suggestions and then filter them out, it would be cool if more people came here with more suggestions.
What could be a nice new logos per PR, 1, 3, 5? I can add the license in the new PR, most of the icons I get them from wikimedia.commons.org
I know it, even adding 50 new logos the font would arrive to 30%, I get that we need to be more selective. Do you have suggestions for different rendering engines to test? |
Maybe were added by the header generator cause don't belong to any of the adjacent icons.
It's the original icons, I also though about those dots since the size of the used icon is expected to be small we could remove them. About the thin lines I like the changes of the GIMP, OpenBSD, X.org icons, they get better clarity. |
Maybe we should add a disclaimer like the one from simple-icons? I'll try to be more selective. |
I update the table. Also didn't find kdenlive in the cheatsheet, is an update missing? About the simple-logos availability, that will work for the server users but not for desktop/terminal users, maybe we can prefer to add logos from OSS that have a file extension related to it? maybe also distros/DE/WM? |
Hej @hasecilu, thanks for all the work. Lets see if I have some answers.
Ah, right. But then the higher amount of control points is not surprising I guess. It sounded like you did not expect it.
For me, it would be 1, 3, or 5 ;-) Or maybe even 'just distros' and 'just WM'.
From my experience the wikimedia svgs are not the best. For example the 'new fedora' logo that got pulled here. The wikimedia svg was slightly out-of-ascpect-ratio. Best is always to use the official svgs, i.e. from the project repo itself. Usually there you also see the terms and conditions (license). These also tend to be ignored by wikimedia. It is just easier to review icon additions if there is at least a link to the license (the original one, not wikimedia). /shrug
Well, I usually
See for example where we had an issue
No, the svg itself is problematic; they are in it: Manual test import of svg in some existing font It is the last I will check that out.
Edit: I guess you answered to the Wayland icon already above, so my comment is ... |
The 'eyes' are Objects and not Paths. After conversion "Object to Path" in inkscape it works ok: The new svg is hidden (for download) here: This is why I usually check the svgs in a text editor; to make sure they are all paths and nothing else which might confuse Fontforge. Ah and I forgot... Crystal is a programming language but that has a different icon which is in NF. So: 👍 Edit: The Crystal in simple-icons is also the lang and not the distro, so I removed that tickmark in the table And
Well, there is a high probablility that simple-icons will be added to NF, that would double all that icons in NF (I mean if we also add them here). This might or might not be related or important to this PR, but maybe it is, that is why I detailed on that. And... How do you want to proceed? Should I work on some svgs and commit the changes here? Should I just check? Etc ;) |
Oh no, forgot more things...
I also did not find it. Maybe I worked on the icon in some other-than-NF context?
I also find their |
@hasecilu What is the state of this? The next Nerd Font release is imminent and I would like to have this in, if possible. |
Ok, pursuing this to get a new release soon... These are all the icons in the PR, and I will go through each svg manually (will edit this comment frequently): Distributions
Distributions without a
Some Projects
[1] We traced (converted to svg) https://logosbynick.com/wp-content/uploads/2019/06/Logo.png Window Managers
Other
|
See #93 (comment) Signed-off-by: Fini Jastrow <[email protected]>
Pulled out all the icons with a tickmark above into a smaller new PR while keeping @hasecilu's original commit in place. |
Oops, the automatism closed this (because #98 pulled all the commits that are in here. But that reverted some changes again... Reopening, as this is not completely merged. |
Hmm, I can neither reopen this nor push some (empty) commits to the branch to make this non-closed :-/ |
Sorry! I tried a lot of things and I am unable to make this PR open again, and I can not push anything to it, and I can not revert the merge, even with force pushes. |
Thanks a lot for your hard work, @Finii ! |
Most work has been done by @hasecilu , I just look over the stuff, sort and merge. But thank you :) |
Hi, sorry for the absence I've been busy for last weeks, just Saturday morning here I'm checking the repo and see a lot of progress, thanks to both of you! |
Great! I broke the icons apart in 'sets' in the follow up PR #99. Maybe you want to create new PRs one per 'topic/set'? Left out Vanilla OS, because it seemed not relevant enough. There are just too many distributions ;) Meanwhile I will polish the release workflow. |
The new logos are from:
NOTE: I didn't include the README banner because the generated image had a gray background making the banner no legible, besides that with the number of logos I think I will look better with 3 rows, 600 px width on html file lgtm.Closes: #90 #88 #83