Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to 3.6 #6

Closed
wants to merge 2 commits into from
Closed

Conversation

bastianallgeier
Copy link
Contributor

This is first rough step to migrate the plugin to 3.6.

I wasn't fully able to connect the git worktree properly in my test. But normally only the view should be the problem in 3.6.

I have to say that the permission handling in 3.6 could be better. It's clashing a bit with your custom permissions. I will need to look into that again. But I hope the PR still helps. Would love to hear your thoughts.

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #6 (e004879) into main (cf36829) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                main        #6   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       156       156           
===========================================
  Files              6         6           
  Lines            455       455           
===========================================
  Hits             455       455           
Flag Coverage Δ
backend 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf36829...e004879. Read the comment docs.

@lukasbestle
Copy link
Owner

@bastianallgeier Thank you very much for the PR, it's a huge help. I will make further tests with my local setup. I already really love how much simpler the setup is.

lukasbestle added a commit that referenced this pull request Oct 2, 2021
Co-authored-by: Bastian Allgeier <[email protected]>
lukasbestle added a commit that referenced this pull request Oct 2, 2021
Closes #6.

Co-authored-by: Bastian Allgeier <[email protected]>
@lukasbestle lukasbestle closed this Oct 2, 2021
@lukasbestle
Copy link
Owner

I also had to migrate from k-list-item to k-item, but apart from that it worked quite smoothly. You can check it out on the develop branch.

lukasbestle added a commit that referenced this pull request Oct 2, 2021
Closes #6.

Co-authored-by: Bastian Allgeier <[email protected]>
lukasbestle added a commit that referenced this pull request Oct 3, 2021
Closes #6.

Co-authored-by: Bastian Allgeier <[email protected]>
lukasbestle added a commit that referenced this pull request Oct 9, 2021
Closes #6.

Co-authored-by: Bastian Allgeier <[email protected]>
@lukasbestle
Copy link
Owner

lukasbestle commented Oct 27, 2021

For reference: The plugin version 1.0.1 comes with full support for Kirby 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants