-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to 3.6 #6
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 156 156
===========================================
Files 6 6
Lines 455 455
===========================================
Hits 455 455
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@bastianallgeier Thank you very much for the PR, it's a huge help. I will make further tests with my local setup. I already really love how much simpler the setup is. |
Co-authored-by: Bastian Allgeier <[email protected]>
Closes #6. Co-authored-by: Bastian Allgeier <[email protected]>
I also had to migrate from |
Closes #6. Co-authored-by: Bastian Allgeier <[email protected]>
Closes #6. Co-authored-by: Bastian Allgeier <[email protected]>
Closes #6. Co-authored-by: Bastian Allgeier <[email protected]>
For reference: The plugin version 1.0.1 comes with full support for Kirby 3.6. |
This is first rough step to migrate the plugin to 3.6.
I wasn't fully able to connect the git worktree properly in my test. But normally only the view should be the problem in 3.6.
I have to say that the permission handling in 3.6 could be better. It's clashing a bit with your custom permissions. I will need to look into that again. But I hope the PR still helps. Would love to hear your thoughts.