fix: transient eperm errors on windows #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/eperm-plus-misc
branch
3 times, most recently
from
cfee0e1 to
9105b1b
Compare
This removes the need for checking test only environs in the bin script.
This removes the need for a separate platform.js file and test environ.
This refactors the `src/rimraf-*` files to use `fixEPERM` and `ignoreENOENT` everywhere possible. The biggest churn here is updating the test files to correctly mock the necessary FS functions that are now spread across multiple files.
lukekarrys
force-pushed
the
lk/eperm-plus-misc
branch
from
9105b1b to
ab88b5e
Compare
lukekarrys
force-pushed
the
lk/eperm-plus-misc
branch
3 times, most recently
from
45ce90f to
784cd09
Compare
eperm stuff make sure other test still run guard against eperm during windows readdir
lukekarrys
force-pushed
the
lk/eperm-plus-misc
branch
from
784cd09 to
26eebea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.