-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to define transition type when defining route #63
Conversation
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 50.28% 50.28% -0.01%
==========================================
Files 3 3
Lines 173 175 +2
==========================================
+ Hits 87 88 +1
- Misses 86 87 +1
Continue to review full report at Codecov.
|
Any update on this? |
There are a couple of things:
I think there are a few other changes needed until this can be merged. For example: You will probably want to eliminate the default on the optional transition for You probably also want to make transition optional on the route with null as the default value. |
…nal (non-positional) and null by default. other fixes. NEEDS TESTING
I've done all the fixes here: https://github.com/lukef/fluro/tree/lf-route-trans. Want to take a look? It needs testing before I can merge. |
@lukef You branch looks good many thanks. I'll clone it and test. |
Let me know when you think it's ready and I'll smoke test and we can be good to go. |
Thanks all ! |
@lukef I'm really sorry for the insane delay getting back to you! I've just had a play with your changes for this and it is working really well. Thanks again for the changes. I realize this is a couple of releases behind the main repo so let me know if you want me to do a PR to update your fork of this so we can merge. Thanks again! |
This look awesome, can we get a release with that? |
If you can resolve the conflicts I'll do a release |
@lukef this PR is now updated from your working fork and the changes from master have also been merged in. I also added a line to the readme file to indicate how to specify a route transition when defining a route. Hopefully this is good to go now 👍 |
@lukef any chance we can get this merged in and released? |
1.4.0 is published |
Also updated the test dependency in pubspec.yaml.
This is just a first pass to get your thoughts...
It should cover the enhancements needed for #27