Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to define transition type when defining route #63

Merged
merged 5 commits into from
Dec 13, 2018

Conversation

jonsamwell
Copy link
Contributor

Also updated the test dependency in pubspec.yaml.

This is just a first pass to get your thoughts...

It should cover the enhancements needed for #27

@codecov-io
Copy link

codecov-io commented Sep 9, 2018

Codecov Report

Merging #63 into master will decrease coverage by <.01%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   50.28%   50.28%   -0.01%     
==========================================
  Files           3        3              
  Lines         173      175       +2     
==========================================
+ Hits           87       88       +1     
- Misses         86       87       +1
Impacted Files Coverage Δ
lib/src/common.dart 44.44% <100%> (+6.94%) ⬆️
lib/src/router.dart 7.35% <33.33%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e35c5...45b607f. Read the comment docs.

@jonsamwell
Copy link
Contributor Author

Any update on this?

@lukef
Copy link
Collaborator

lukef commented Sep 14, 2018

There are a couple of things:

  1. It looks to be broken. I just ran the example app and the transitions are all executing the "native" transition.
  2. Any transition passed via navigateTo should always take priority over anything defined at the route level (doesn't seem the case now)

I think there are a few other changes needed until this can be merged. For example: You will probably want to eliminate the default on the optional transition for navigateTo and check for null later otherwise you wont be able to test to see if it has been set to override.

You probably also want to make transition optional on the route with null as the default value.

…nal (non-positional) and null by default. other fixes. NEEDS TESTING
@lukef
Copy link
Collaborator

lukef commented Sep 14, 2018

I've done all the fixes here: https://github.com/lukef/fluro/tree/lf-route-trans. Want to take a look? It needs testing before I can merge.

@jonsamwell
Copy link
Contributor Author

@lukef You branch looks good many thanks. I'll clone it and test.

@lukef
Copy link
Collaborator

lukef commented Sep 17, 2018

Let me know when you think it's ready and I'll smoke test and we can be good to go.

@lukef lukef added this to the 1.4.0 milestone Sep 17, 2018
@lukef lukef added enhancement Suggested feature or enhancement to the library. testing We're preparing to release it but it needs a few more tests. labels Sep 17, 2018
@ghost
Copy link

ghost commented Sep 17, 2018

Thanks all !

@jonsamwell
Copy link
Contributor Author

jonsamwell commented Oct 31, 2018

@lukef I'm really sorry for the insane delay getting back to you!

I've just had a play with your changes for this and it is working really well. Thanks again for the changes.

I realize this is a couple of releases behind the main repo so let me know if you want me to do a PR to update your fork of this so we can merge.

Thanks again!

@Benoss
Copy link

Benoss commented Nov 7, 2018

This look awesome, can we get a release with that?

@jonsamwell
Copy link
Contributor Author

@Benoss it is awesome! I'm just waiting on @lukef to see if he wants me to update his fork of this PR so it can be merged into the main branch without any conflicts.

@lukef
Copy link
Collaborator

lukef commented Nov 7, 2018

If you can resolve the conflicts I'll do a release

@jonsamwell
Copy link
Contributor Author

jonsamwell commented Nov 8, 2018

@lukef this PR is now updated from your working fork and the changes from master have also been merged in. I also added a line to the readme file to indicate how to specify a route transition when defining a route. Hopefully this is good to go now 👍

@jonsamwell
Copy link
Contributor Author

@lukef any chance we can get this merged in and released?

@lukef lukef merged commit a11dd62 into lukepighetti:master Dec 13, 2018
@lukef
Copy link
Collaborator

lukef commented Dec 21, 2018

1.4.0 is published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggested feature or enhancement to the library. testing We're preparing to release it but it needs a few more tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants