Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code #4

Open
lukesonnet opened this issue Jul 22, 2017 · 1 comment
Open

Clean up code #4

lukesonnet opened this issue Jul 22, 2017 · 1 comment
Assignees

Comments

@lukesonnet
Copy link
Owner

  • Read through and simplify code
  • Format according to Google's R style guide unless it is a big problem for backwards compatability
  • Update documentation
@lukesonnet lukesonnet self-assigned this Jul 22, 2017
@lukesonnet
Copy link
Owner Author

Finished auditing the R code. I didn't audit every function description or comment, but a good read through of the actual code. I also didn't format for style, for the most part. I'll do the cpp tomorrow.

All the changes worth noting, I think:

things that change usage

-Removed lambdaline and lambdapenalty options
-setting epsilon triggers truncation, truncation triggers default epsilon if not set. Also, warns if not truncating and n>=1000
-Removed sandwich argument from inference... if robust or clustered, then we will be sandwich estimator no matter what so robust and sandwich were redundant. We might want default to be sandwich instead of just inv hessian for KRLogit, but that's up to you
-Removed svd dependency and options to use it instead of RSpectra for eigen decompositions
-added an argument called lambdainterval, which sets the interval used in the optimize command, defaults to c(10^-12, 4)
-updated documentation on krls2

things that don't change usage

-Consolidated hyperctrl and control
-moved around some comments and some printing to make everything prettier, less 'debug' mode like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant