Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lume 3 #714

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from
Draft

Lume 3 #714

wants to merge 57 commits into from

Conversation

oscarotero
Copy link
Member

@oscarotero oscarotero commented Jan 4, 2025

Changes for the future Lume 3

Test it:

deno task lume upgrade --dev --version=v3-dev

@oscarotero oscarotero added this to the v3 milestone Jan 4, 2025
@RickCogley
Copy link
Contributor

The site.copy is the biggest thing for me. Would there be value to adding a couple more deno commands to the macros in deno.json, such as fmt or lint?

@oscarotero
Copy link
Member Author

oscarotero commented Jan 9, 2025

@RickCogley I'm not sure this worth it since you can run deno fmt instead of deno task fmt.

@RickCogley
Copy link
Contributor

True! It just overcomplicates things

@scarf005
Copy link
Contributor

idea: better component HMR for {j,t}sx? files

@oscarotero
Copy link
Member Author

@scarf005 do you mean reloading modules in --server mode?

@scarf005
Copy link
Contributor

scarf005 commented Jan 10, 2025

@scarf005 do you mean reloading modules in --server mode?

if you mean deno task serve, yes

@oscarotero
Copy link
Member Author

oscarotero commented Jan 10, 2025

AFAIK, HMR in the browser is hard and it depends on the framework (is different in React and Vue).
Unless we have a weight dependency like Vite or similar, I'm not sure how we can do this.
But if you have a specific approach in mind, please let me know

@rdela
Copy link

rdela commented Jan 10, 2025

As always, I am for keeping Lume as lean as possible.

As Dan Forsyth observed, “elegance is power cloaked in simplicity.”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants