Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inline): append new classes to existing ones #722

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

sagikazarmark
Copy link
Contributor

@sagikazarmark sagikazarmark commented Jan 19, 2025

Description

When inlining resources with attributes (eg. SVG), classes will now be appended to an existing list of classes (instead of being ignored).

Related Issues

Fixes #721

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@sagikazarmark
Copy link
Contributor Author

deno fmt formats code that I haven't touched, so I skipped running it. Code changed by this PR seems to follow the formatting rules.

@oscarotero
Copy link
Member

Probably it's some change in the formatter introduced in the latest version of Deno.
Anyway, your code looks great, so I'm going to merge it and will re-run the fmt to the whole code repo.

@oscarotero oscarotero merged commit b698b44 into lumeland:main Jan 19, 2025
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override/append attributes when inlining SVG images
2 participants