Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed plugin: Add options info.image, info.icon and info.color #723

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

castaneai
Copy link
Contributor

Description

Add option to add custom fields to RSS feed output. This can be used as extended metadata for Feedly, for example.

refs:

Related Issues

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@oscarotero
Copy link
Member

I'm okay with adding support for Feedly, but I'd rather to have good defaults instead of adding manually these fields.
What do you think about the following changes?

  • Add xmlns:webfeeds="http://webfeeds.org/rss/1.0" and `version="2.0" to the XML. No need to configure it.
  • Extend the FeedInfoOptions interface with color, image and icon properties. This also matches with Metas plugin that have these properties.
  • Some of these properties are also supported by JSON Feed, (like icon for example), so we should modify the JSON generation to use them.

@castaneai
Copy link
Contributor Author

Thanks, @oscarotero.
That change sounds like a good one! I'm willing to take a little time to adopt those changes.

@oscarotero
Copy link
Member

Great! Thank you!

@castaneai castaneai changed the title Feed plugin: Add customFields support Feed plugin: Add options info.image, info.icon and info.color Jan 23, 2025
@castaneai
Copy link
Contributor Author

I have rewritten it to three options: image, icon and color.

@oscarotero oscarotero merged commit 9b11d7f into lumeland:main Jan 23, 2025
@oscarotero
Copy link
Member

oscarotero commented Jan 23, 2025

It's perfect. Thank you!

@castaneai castaneai deleted the feed-custom-fields branch January 23, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants