Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative path profile - refactoring to configurable variables #327

Merged
merged 2 commits into from
Nov 3, 2017

Conversation

nrakochy
Copy link
Contributor

@nrakochy nrakochy commented Nov 3, 2017

This sets the generated path as a template param which can be configurable in luminus.clj (at this point simply set to :default).

The rationale for this would be the ability to add additional profiles to the template that would allow different project structures (think Docker services, for example).

That said, perhaps it is too much overhead, so I will defer to you if you think it is useful or not. Thanks for the great template...

@yogthos
Copy link
Member

yogthos commented Nov 3, 2017

Looks like a clean way to approach this.

@yogthos yogthos merged commit 9d2b27f into luminus-framework:master Nov 3, 2017
@Ramblurr
Copy link

Ramblurr commented Dec 27, 2017

@yogthos @nrakochy Since this commit a fresh project with +sass is broken:

lein new luminus test  +sassc 
cd test
lein run 

=>

Compile SASS/SCSS files.
sassc -t nested -I {{resource-path}}/scss {{resource-path}}/scss/screen.scss {{resource-path}}/public/css/screen.css
Internal Error: File to read not found or unreadable: {{resource-path}}/scss/screen.scss

edit: created standalone issue for this #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants