Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Remove Unneeded call to cider/wrap-cljs-repl #414

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

skyefreeman
Copy link
Contributor

Problem:

On a freshly generated Leiningen template which included cljs, I noticed starting Figwheel and the corresponding cljs repl caused the following output:

Figwheel: Starting server at http://0.0.0.0:3449
Figwheel: Watching build - app
Compiling build :app to "target/cljsbuild/public/js/app.js" from ["src/cljs" "src/cljc" "env/dev/cljs"]...
Successfully compiled build :app to "target/cljsbuild/public/js/app.js" in 1.062 seconds.
Figwheel: Starting CSS Watcher for paths  ["resources/public/css"]
Figwheel: Starting nREPL server on port: 7002
WARNING: unable to load "cider/wrap-cljs-repl" middleware
...

Solution

  • After some digging, it doesn't seem like cider/wrap-cljs-repl is a valid namespace or function, and looks superfluous alongside cider.piggieback/wrap-cljs-repl.
  • While the above warning wasn't causing any noticeable issues with the repl instance, the warning looks unwanted 😄

@yogthos
Copy link
Member

yogthos commented Jan 29, 2019

Ah, great catch and thanks for the PR! :)

@yogthos yogthos merged commit bf007f6 into luminus-framework:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants