Skaia cathedral #641
Open
Skaia cathedral #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it will be best to wait until 1.21 is ready to merge this! I can help you with rebasing it when the time comes and after that point I will review it properly. Great work! |
Dweblenod
reviewed
Nov 24, 2024
There was a problem hiding this comment.
Alright review time! This is almost ready to go but there are a few things to take care of first:
- One of the cruxite lanterns is turned off within the front piece. You could try using an nbt editor to fix that, try fixing it yourself in-game, or getting Medli(Shadow Link) to do it in-game.
- The skaia biome tag is currently unused. If you meant to use it in structure/skaiancathedral.json then make sure to change the entry in "biomes" from "minestuck:skaia" to "#minestuck:skaia"!
- To keep our formatting consistent, make sure anything named after the structure has an underscore in it. Such that anything called "skaiancathedral" becomes "skaian_cathedral". On that note I would also suggest (not a requirement) that the files in "structure/skaian_cathedral/" and "template_pool/skaian_cathedral/" share the same naming scheme
…edral # Conflicts: # src/main/java/com/mraof/minestuck/data/worldgen/MSStructureProvider.java # src/main/java/com/mraof/minestuck/world/gen/structure/MSStructures.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a Skaian Cathedral(build designed by ambiguousChronology (ShadowLink))