Add tax rate editing to the panel #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…php/lunar into lun-100-tax-editing-in-admin-panel
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
glennjacobs
requested changes
Aug 22, 2024
There was a problem hiding this comment.
@alecritson As we improve tax editing in the admin panel, let's also switch to using a Filament cluster to consolidate the three tax resources: Tax Classes, Tax Zones, and Tax Rates.
See https://filamentphp.com/docs/3.x/panels/clusters
…php/lunar into lun-100-tax-editing-in-admin-panel
…php/lunar into lun-100-tax-editing-in-admin-panel
|
@alecritson trying to edit a tax rate gives this incorrect error 
|
glennjacobs
requested changes
Aug 22, 2024
There was a problem hiding this comment.
@alecritson When adding "Tax Rate Amounts" it allows us to add duplicate entries for the same "Tax Class".
Also, there is no facility to delete a Tax Rate Amount, only edit.
glennjacobs
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.