Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github actions workflows to use the latests versions actions #22

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

dbabokin
Copy link
Collaborator

@dbabokin dbabokin commented Jul 29, 2024

Related to #21

Update Github actions workflows to use the latest versions of actions.

  • Update actions/checkout to version v4.1.7 in .github/workflows/build.yml.
  • Update actions/upload-artifact to version v4.3.4 in .github/workflows/build.yml.
  • Update MarkusJx/install-boost to version v2.4.5 in .github/workflows/build.yml.

For more details, open the Copilot Workspace session.

Related to #21

Update Github actions workflows to use the latest versions of actions.

* Update `actions/checkout` to version `v4.1.7` in `.github/workflows/build.yml`.
* Update `actions/upload-artifact` to version `v4.3.4` in `.github/workflows/build.yml`.
* Update `MarkusJx/install-boost` to version `v2.4.5` in `.github/workflows/build.yml`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/lunarserge/Numero/issues/21?shareId=XXXX-XXXX-XXXX-XXXX).
@dbabokin
Copy link
Collaborator Author

Update GitHub Actions workflow to run on push to main branch only

  • Add branch filter to push event to avoid triggering twice for pull requests

For more details, open the Copilot Workspace session.

* Add branch filter to push event to avoid triggering twice for pull requests

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/lunarserge/Numero/pull/22?shareId=XXXX-XXXX-XXXX-XXXX).
@dbabokin
Copy link
Collaborator Author

Mac fails dues to boost using std::unary_function, which was removed in C++17 and looks like on macOS compiler is more strict about it. Looks like the way to go is to update the boost version.

@dbabokin
Copy link
Collaborator Author

Update boost version to 1.85.0 in GitHub Actions workflow

  • Windows build

    • Change boost version from 1.79.0 to 1.85.0
    • Update actions/checkout to v4
    • Update actions/upload-artifact to v4
  • Linux build

    • Change boost version from 1.79.0 to 1.85.0
    • Update actions/checkout to v4
    • Update actions/upload-artifact to v4
  • Mac build

    • Change boost version from 1.79.0 to 1.85.0
    • Update actions/checkout to v4
    • Update actions/upload-artifact to v4

For more details, open the Copilot Workspace session.

dbabokin added 2 commits July 29, 2024 15:17
* **Windows build**
  - Change boost version from 1.79.0 to 1.85.0
  - Update actions/checkout to v4
  - Update actions/upload-artifact to v4

* **Linux build**
  - Change boost version from 1.79.0 to 1.85.0
  - Update actions/checkout to v4
  - Update actions/upload-artifact to v4

* **Mac build**
  - Change boost version from 1.79.0 to 1.85.0
  - Update actions/checkout to v4
  - Update actions/upload-artifact to v4

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/lunarserge/Numero/pull/22?shareId=XXXX-XXXX-XXXX-XXXX).
* Change `platform_version` for macOS from 11 to 14 in `.github/workflows/build.yml`

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/lunarserge/Numero/pull/22?shareId=XXXX-XXXX-XXXX-XXXX).
@dbabokin
Copy link
Collaborator Author

Update platform version for macOS in GitHub Actions workflow

  • Change platform_version for macOS from 11 to 14 in .github/workflows/build.yml

For more details, open the Copilot Workspace session.

* **macOS build:**
  - Add `arch: aarch64` to the `install-boost` step to specify the architecture for Boost setup.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/lunarserge/Numero/pull/22?shareId=XXXX-XXXX-XXXX-XXXX).
@dbabokin
Copy link
Collaborator Author

Update macOS build configuration in GitHub Actions workflow

  • macOS build:
    • Add arch: aarch64 to the install-boost step to specify the architecture for Boost setup.

For more details, open the Copilot Workspace session.

@dbabokin dbabokin requested a review from lunarserge July 30, 2024 00:14
@dbabokin
Copy link
Collaborator Author

CI is updated and it looks good to me now.

@dbabokin
Copy link
Collaborator Author

dbabokin commented Aug 5, 2024

This needs to be merged to fix CI.

Copy link
Owner

@lunarserge lunarserge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbabokin dbabokin merged commit d0f26b6 into master Aug 6, 2024
3 checks passed
@dbabokin dbabokin deleted the dbabokin/update-github-actions branch August 6, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants