Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split lune into proper crates #188

Merged
merged 68 commits into from
May 12, 2024
Merged

Split lune into proper crates #188

merged 68 commits into from
May 12, 2024

Conversation

filiptibell
Copy link
Collaborator

@filiptibell filiptibell commented Apr 21, 2024 •
edited
Loading

This PR splits the lune megacrate and standard library into several smaller crates. Its main goals are:

  • Clearer separation of concerns and dependencies
  • Improved incremental compilation times, and possibly codegen
  • Sub-crates should be consumable by other projects outside of Lune

Implementation notes

Workspace configuration for clippy lints has also been added, and now applies to all crates. These new lints are also fixed in this same PR.

Any common utilities have been rewritten and put into a common lune-utils crate by necessity. This new crate will be kept as small as possible since all other Lune crates depend on it, and because it will be indirectly depended on by any consumer outside of Lune itself.

Information for contributors

While this PR is being worked on it is unlikely for other PRs to get merged since it involves larger structural changes to Lune. Hopefully, once it has been merged, contributing to Lune will be even easier than before.

@filiptibell
Set up workspace manifest and move lune crate into crates dir
91fd9d9
@filiptibell
Remove automated cargo publish workflow
99a8fa3
@filiptibell
Add all crates for standard library to workspace
e53d247
@filiptibell
Add utils crate
5c5ea5b
@filiptibell
Add table builder to utils crate
13309ba
@filiptibell
Allow unnecessary wraps and similar names lints
34e1165
@filiptibell
Port task library to new crate
a5e349c
@filiptibell
Migrate stdio builtin to new crate
ac3721f
@filiptibell
Create full enum for lune standard libraries
3b3fa65
@filiptibell
Add version string to lune-utils crate
121afae
@filiptibell
Fix lune tests running from the wrong dir
0bb9786
@filiptibell
Mostly port globals to lune-std crate
136cb7d
@filiptibell
Collect path-related functions in lune-utils crate
cf7e1f3
@filiptibell
Add luaurc to lune-utils crate, resolve issues with require in lune-std
a714efd
@filiptibell
Fix version string using lune-utils version instead of lune version, …
5a52a51 
…add inject_globals to lune-std
@CompeyDev CompeyDev mentioned this pull request Apr 22, 2024
Merged
4 tasks
@filiptibell
Reimplement stdio color and style apis, more strict types and helpful…
f51a4a0 
… errors
@filiptibell
Start lune std and utils crate versions at 0.1.0
5ad6b9a
@filiptibell
Start implementing fmt module in lune-utils
b04c0c2
@filiptibell
Add example usage doc to label enum
896121a
@filiptibell
Start work on error parser in lune-utils
4e00bcf
@filiptibell
Enable mlua luau feature in all crates
7c702e4
@filiptibell
Initial working version of new error parser and display
6dad31d
@filiptibell
Add mechanism for using custom global version instead of lune-std cra…
e983b60 
…te version
@filiptibell
Initial implementation of new value formatter
3433fb4
@filiptibell
Add note about results in value format impl
7f80093
@filiptibell
Properly support recursive table formatting and multithreaded use
ed409a6
@filiptibell
Reimplement printing globals and stdio.format using new formatter
5d94188
@filiptibell
Migrate datetime builtin to lune-std-datetime crate
7fff3cb
@filiptibell
Migrate fs builtin to lune-std-fs crate
d947355
@filiptibell filiptibell marked this pull request as ready for review April 23, 2024 17:19
@filiptibell filiptibell marked this pull request as draft April 24, 2024 15:09
@filiptibell filiptibell mentioned this pull request May 9, 2024
Open
filiptibell added 21 commits May 10, 2024 15:17
@filiptibell
Fix old version of scheduler crate being used
a84994b
@filiptibell
Fix net serve test port being taken
8f5b5ee
@filiptibell
Start making script to generate compressed test files
8a3f84c
@filiptibell
Add diffs in compression generation script
6875353
@filiptibell
Add sanity check to make sure serde decompress passes first
7513ea3
@filiptibell
Fix arg
803c8c0
@filiptibell
Log output of compression tools after run
d11bb16
@filiptibell
Fix gzip test file having os flag embedded in it
ba39039
@filiptibell
Handle decompress errors better
57323e5
@filiptibell
Show file diff before trying to decompress
237da52
@filiptibell
Fix newlines being on their own lines
286c659
@filiptibell
Almost fix lz4
160987c
@filiptibell
lz4-flex does not support high compression level
48dd07e
@filiptibell
Migrate to lz4 crate to be able to decode hc mode
5c454eb 
lz4-flex unfortunately does not support this and we should prefer compatibility over maximum speed
@filiptibell
Find a cli that does raw zlib, fix zlib test file
2f6dec4
@filiptibell
Make output of generation script friendlier
ec5625a
@filiptibell
Even friendlier still
ae1ab35
@filiptibell
Try to fix test runner on Windows
2a7a198
@filiptibell
Add publishing to crates.io in release workflow
d951361
@filiptibell
Update action versions in github workflows
e72766a
@filiptibell
Update tooling, run formatting
9ae5727
@filiptibell filiptibell marked this pull request as ready for review May 12, 2024 11:23
@filiptibell filiptibell merged commit de71558 into main May 12, 2024
12 checks passed
@filiptibell filiptibell deleted the split-into-crates branch May 12, 2024 11:30
@BrewTestBot BrewTestBot mentioned this pull request May 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@filiptibell