Feature: Implement a REPL #83

CompeyDev · 2023-08-11T06:34:55Z

As requested by users before, this PR includes a REPL functionality which is invoked when Lune is run with no positional arguments. The REPL currently supports

Evaluation
Clean exits (^C & ^D)
Execution history
~~Preservation of code "context" (variables declared in previous steps)~~
- This has proven to be tough and should have a separate PR entirely dedicated to it. There are simply too many moving parts and is therefore out of scope for now.

What needs to be implemented/fixed:

~~Context preservation for other declaratives (such as functions, or globals)~~
~~Global variable detections for pretty printing~~
Allow user to enter additional code if the statement is incomplete

Closes #38.

This allows the REPL to now preserve context, such as previously declared variables which can be used in future eval steps. Currently is only supported for variables, support for other types to be included soon.

filiptibell

Thank you for the PR! This looks good overall, I left a few comments to resolve.

RE: "Allow user to enter additional code if the statement is incomplete" I think following the example in the mlua repository would work well here too: https://github.com/khvzak/mlua/blob/0e4476c2e3be679552b110add270b2fd0f8fd2a0/examples/repl.rs#L33-L40

Cargo.toml

src/cli/repl.rs

src/lib.rs

u-train · 2023-08-13T23:43:33Z

An inquiry as a passer-by, would it be possible to have the REPL as a Lune application instead of it being implemented in Rust? It would make things easier by the looks of it, and it would be dogfooding Lune to itself.

CompeyDev · 2023-08-14T10:40:28Z

An inquiry as a passer-by, would it be possible to have the REPL as a Lune application instead of it being implemented in Rust? It would make things easier by the looks of it, and it would be dogfooding Lune to itself.

As per various standards, REPLs are the in-built into interpreters, for quick code execution.

* makes use of `directories` instead of `home` * use `anyhow::Result` instead of more verbose `Result<_, anyhow::Error>` * removes redundant match statement * removes NO_COLOR logic, already handled by `console` library

CompeyDev · 2023-08-14T14:49:20Z

A question: As per the mlua REPL example, they check whether the error is for an "incomplete input" as such.

In the case of lune, a LuneError is returned, which does not provide details about the error at all. How do I go about getting the type of error it is?

filiptibell · 2023-08-14T15:45:05Z

In the case of lune, a LuneError is returned, which does not provide details about the error at all. How do I go about getting the type of error it is?

I added is_incomplete_input to LuneError in 0ab32ff , I think this should help

CompeyDev · 2023-08-14T16:28:15Z

is_incomplete_input

Awesome! Will implement.

CompeyDev · 2023-08-14T17:02:03Z

I've implemented the input continuation feature, lmk if any changes required regarding that.

CompeyDev · 2023-08-14T17:34:13Z

The only thing I see unsatisfactory at the moment is this direct exit. I'll see what I can do to remove its usage.

src/cli/repl.rs

filiptibell · 2023-08-14T20:39:47Z

I've implemented the input continuation feature, lmk if any changes required regarding that.

Looks good to me!

The only thing I see unsatisfactory at the moment is this direct exit. I'll see what I can do to remove its usage.

I added some more review comments that you should be able to just click accept on, after this I think CI should also pass and we should be good to go

Co-authored-by: Filip Tibell <[email protected]>

CompeyDev · 2023-08-15T06:05:51Z

I've implemented the input continuation feature, lmk if any changes required regarding that.

Looks good to me!

The only thing I see unsatisfactory at the moment is this direct exit. I'll see what I can do to remove its usage.

I added some more review comments that you should be able to just click accept on, after this I think CI should also pass and we should be good to go

Gone ahead and accepted the changes, apologies for my stupidity at some times! 😅

fewkz · 2023-08-15T21:31:07Z

Without "context", this isn't really that helpful. I fear the "adding context support later" will never end up being added and we'll be stuck with a pointless repl. You can already run lune code from the command line by doing lune -, so this doesn't exactly add anything new. At the very least, I'd prefer my issue to not be closed.

filiptibell · 2023-08-16T01:59:51Z

Without "context", this isn't really that helpful.

Context preservation would be blocked right now either way since there is no way for the REPL to get/set the function environment of what it wants to run. I'm in the process of rewriting the Lune scheduler right now and when that's done I think we will be able to integrate the REPL a bit more and get context preservation working. If you want to still keep the issue open though feel free to reopen it or even make a new issue for context preservation

CompeyDev · 2023-08-16T13:51:18Z

Without "context", this isn't really that helpful. I fear the "adding context support later" will never end up being added and we'll be stuck with a pointless repl. You can already run lune code from the command line by doing lune -, so this doesn't exactly add anything new. At the very least, I'd prefer my issue to not be closed.

As for now, you could use one-liners separated by semi-colors (even though that's not very convenient), and it will serve the same purposes. At the moment, the REPL is an MVP, similar to what is already available for Lua 5.4 REPL.

CompeyDev added 13 commits August 6, 2023 16:18

feat(repl): initial implementation

bd594e6

feat: store history & allow for history traversing

09050be

refactor: move REPL logic to separate module

87cca0f

feat: save history to file

6d4fa87

fix: remove unneeded imports as per lint

7b26349

feat: error formatting

508c283

feat: initial context preservation

f9919a4

This allows the REPL to now preserve context, such as previously declared variables which can be used in future eval steps. Currently is only supported for variables, support for other types to be included soon.

fix: improved regex pattern, removes backrefs

37c8582

chore(deps): remove fancy-regex

f4f3040

chore: fix conflicts

f1467f9

Merge branch 'main' into feature/repl

93a265d

refactor: remove unnecessary context preservation code

35a29a1

Merge branch 'main' into feature/repl

23f8a24

filiptibell requested changes Aug 13, 2023

View reviewed changes

fix: remove dev profile from Cargo.toml

7ee5b09

CompeyDev added 3 commits August 14, 2023 16:14

refactor: implemented requested changes

431f0ff

* makes use of `directories` instead of `home` * use `anyhow::Result` instead of more verbose `Result<_, anyhow::Error>` * removes redundant match statement * removes NO_COLOR logic, already handled by `console` library

fix: write to lune_history file, not homedir

a3f88fa

fix: remove testing code

1051d55

fix: remove orphan testing code

bef0df6

CompeyDev added 2 commits August 14, 2023 22:01

Merge branch 'main' into feature/repl

b0e52bc

feat: impl input continuation

90d51ae

refactor: simplify history file path err handling

aa50d3e

filiptibell requested changes Aug 14, 2023

View reviewed changes

src/cli/repl.rs Outdated Show resolved Hide resolved

src/cli/repl.rs Outdated Show resolved Hide resolved

src/cli/repl.rs Outdated Show resolved Hide resolved

src/cli/repl.rs Outdated Show resolved Hide resolved

src/cli/repl.rs Outdated Show resolved Hide resolved

CompeyDev and others added 6 commits August 15, 2023 11:32

fix: history file initialization path

57f6985

Co-authored-by: Filip Tibell <[email protected]>

fix: use char separator for source code addition

3ffc914

Co-authored-by: Filip Tibell <[email protected]>

fix: inline error formatting

d02683f

Co-authored-by: Filip Tibell <[email protected]>

fix: inline error formatting (x2)

682bf7c

Co-authored-by: Filip Tibell <[email protected]>

fix: push_str instead of write macro

a2de4eb

Co-authored-by: Filip Tibell <[email protected]>

Merge branch 'main' into feature/repl

5d16f4c

refactor: calm clippy and remove unused imports

f3a7cb2

chore(fmt): format code

12487ca

filiptibell merged commit bff6dff into lune-org:main Aug 16, 2023

filiptibell mentioned this pull request Aug 16, 2023

Add a REPL #38

Closed

chenrui333 mentioned this pull request Aug 24, 2023

lune 0.7.7 Homebrew/homebrew-core#140327

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Implement a REPL #83

Feature: Implement a REPL #83

CompeyDev commented Aug 11, 2023 •

edited

Loading

filiptibell left a comment

u-train commented Aug 13, 2023

CompeyDev commented Aug 14, 2023

CompeyDev commented Aug 14, 2023

filiptibell commented Aug 14, 2023

CompeyDev commented Aug 14, 2023

CompeyDev commented Aug 14, 2023

CompeyDev commented Aug 14, 2023

filiptibell commented Aug 14, 2023

CompeyDev commented Aug 15, 2023

fewkz commented Aug 15, 2023 •

edited

Loading

filiptibell commented Aug 16, 2023

CompeyDev commented Aug 16, 2023

Feature: Implement a REPL #83

Feature: Implement a REPL #83

Conversation

CompeyDev commented Aug 11, 2023 • edited Loading

filiptibell left a comment

Choose a reason for hiding this comment

u-train commented Aug 13, 2023

CompeyDev commented Aug 14, 2023

CompeyDev commented Aug 14, 2023

filiptibell commented Aug 14, 2023

CompeyDev commented Aug 14, 2023

CompeyDev commented Aug 14, 2023

CompeyDev commented Aug 14, 2023

filiptibell commented Aug 14, 2023

CompeyDev commented Aug 15, 2023

fewkz commented Aug 15, 2023 • edited Loading

filiptibell commented Aug 16, 2023

CompeyDev commented Aug 16, 2023

CompeyDev commented Aug 11, 2023 •

edited

Loading

fewkz commented Aug 15, 2023 •

edited

Loading