Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement variadic versions of CFrame methods #85

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Implement variadic versions of CFrame methods #85

merged 1 commit into from
Aug 14, 2023

Conversation

DvvCz
Copy link
Contributor

@DvvCz DvvCz commented Aug 14, 2023

Fixes #74

Now the below functions accept and return a variadic number of arguments.

CFrame:ToWorldSpace
CFrame:ToObjectSpace
CFrame:PointToWorldSpace
CFrame:PointToObjectSpace
CFrame:VectorToWorldSpace
CFrame:VectorToObjectSpace

Please let me know if there's any changes I should make or go about this another way.

I have added a test for ToWorldSpace and ToObjectSpace returning multiple values since they already have coverage, but left the other functions alone

filiptibell
filiptibell approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@filiptibell filiptibell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@filiptibell filiptibell merged commit c86190d into lune-org:main Aug 14, 2023
@DvvCz DvvCz deleted the vararg-cframe branch August 14, 2023 22:23
filiptibell added a commit that referenced this pull request Aug 23, 2023
@filiptibell
Revert #85 to fix SIGSEGV
52a6c4f
@p-linnane p-linnane mentioned this pull request Oct 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptibell filiptibell filiptibell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement varargs versions of CFrame methods
2 participants
@DvvCz @filiptibell