Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass arguments to coroutine in coroutine.resume #86

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Pass arguments to coroutine in coroutine.resume #86

merged 3 commits into from
Aug 14, 2023

Conversation

DvvCz
Copy link
Contributor

@DvvCz DvvCz commented Aug 14, 2023

Fixes #76

Once again please let me know if anything should be changed

filiptibell
filiptibell approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@filiptibell filiptibell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Just a small note - the "coroutine" test is currently failing and ignored in CI pending some larger changes to Lune's scheduler, but thanks for adding the test case here too.

@filiptibell filiptibell merged commit 72adb21 into lune-org:main Aug 14, 2023
@DvvCz DvvCz deleted the resume-arguments branch August 14, 2023 22:22
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptibell filiptibell filiptibell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coroutine.resume doesn't pass values
2 participants
@DvvCz @filiptibell