lint, snapshots, changelog

luniehq · Dec 18, 2018 · 0e1638e · 0e1638e
1 parent 103e2b3
commit 0e1638e
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -132,6 +132,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - [\#1667](https://github.com/cosmos/voyager/issues/1667) Fixed menu in PageSend + hover cursor for menu @sabau
 - [\#1676](https://github.com/cosmos/voyager/issues/1676) Reduced minWidth css for ModalVote to have 2 buttons per line @sabau
 - [\#1676](https://github.com/cosmos/voyager/issues/1670) Update balance in header after voting and depositing @faboweb
+- [\#1572](https://github.com/cosmos/voyager/issues/1572) Fixed scroll bug when switching between tabs @jbibla
 
 ## [0.10.7] - 2018-10-10
 

diff --git a/app/src/renderer/components/governance/PageGovernance.vue b/app/src/renderer/components/governance/PageGovernance.vue
@@ -70,6 +70,9 @@ export default {
   mounted() {
     this.ps = new PerfectScrollbar(this.$el.querySelector(`.tm-page-main`))
   },
+  updated() {
+    this.$el.querySelector(`.tm-page-main`).scrollTop = 0
+  },
   methods: {
     onPropose() {
       this.showModalPropose = true
@@ -102,9 +105,6 @@ export default {
     setSearch(bool = !this.filters[`proposals`].search.visible) {
       this.$store.commit(`setSearchVisible`, [`proposals`, bool])
     }
-  },
-  updated() {
-    this.$el.querySelector(`.tm-page-main`).scrollTop = 0
   }
 }
 </script>
diff --git a/app/src/renderer/components/staking/PageStaking.vue b/app/src/renderer/components/staking/PageStaking.vue
@@ -63,14 +63,14 @@ export default {
     // XXX temporary because querying the shares shows old shares after bonding
     // this.updateDelegates()
   },
+  updated() {
+    this.$el.querySelector(`.tm-page-main`).scrollTop = 0
+  },
   methods: {
     setSearch(bool = !this.filters[`delegates`].search.visible) {
       this.$store.commit(`setSearchVisible`, [`delegates`, bool])
     },
     ...mapActions([`updateDelegates`])
-  },
-  updated() {
-    this.$el.querySelector(`.tm-page-main`).scrollTop = 0
   }
 }
 </script>
diff --git a/test/unit/specs/components/governance/__snapshots__/PageGovernance.spec.js.snap b/test/unit/specs/components/governance/__snapshots__/PageGovernance.spec.js.snap
@@ -61,7 +61,7 @@ exports[`PageGovernance disables proposal creation if not connected 1`] = `
 </menu>
 </div>
 </header>
-<main class=\\"tm-page-main\\">
+<main class=\\"tm-page-main ps\\">
    <!---->
    <!---->
    <div class=\\"tm-page\\" data-title=\\"Wallet\\">
@@ -134,6 +134,12 @@ exports[`PageGovernance disables proposal creation if not connected 1`] = `
 </div>
 </main>
 </div>
+<div class=\\"ps__rail-x\\" style=\\"left: 0px; top: 0px;\\">
+   <div class=\\"ps__thumb-x\\" tabindex=\\"0\\" style=\\"left: 0px; width: 0px;\\"></div>
+</div>
+<div class=\\"ps__rail-y\\" style=\\"top: 0px; left: 0px;\\">
+   <div class=\\"ps__thumb-y\\" tabindex=\\"0\\" style=\\"top: 0px; height: 0px;\\"></div>
+</div>
 </main>
 </div>"
 `;
@@ -278,6 +284,12 @@ exports[`PageGovernance has the expected html structure 1`] = `
 <div class=\\"ps__rail-y\\" style=\\"top: 0px; left: 0px;\\">
    <div class=\\"ps__thumb-y\\" tabindex=\\"0\\" style=\\"top: 0px; height: 0px;\\"></div>
 </div>
+<div class=\\"ps__rail-x\\" style=\\"left: 0px; top: 0px;\\">
+   <div class=\\"ps__thumb-x\\" tabindex=\\"0\\" style=\\"left: 0px; width: 0px;\\"></div>
+</div>
+<div class=\\"ps__rail-y\\" style=\\"top: 0px; left: 0px;\\">
+   <div class=\\"ps__thumb-y\\" tabindex=\\"0\\" style=\\"top: 0px; height: 0px;\\"></div>
+</div>
 </main>
 </div>"
 `;
diff --git a/test/unit/specs/components/staking/__snapshots__/PageStaking.spec.js.snap b/test/unit/specs/components/staking/__snapshots__/PageStaking.spec.js.snap
@@ -138,6 +138,12 @@ exports[`PageStaking has the expected html structure 1`] = `
 <div class=\\"ps__rail-y\\" style=\\"top: 0px; left: 0px;\\">
    <div class=\\"ps__thumb-y\\" tabindex=\\"0\\" style=\\"top: 0px; height: 0px;\\"></div>
 </div>
+<div class=\\"ps__rail-x\\" style=\\"left: 0px; top: 0px;\\">
+   <div class=\\"ps__thumb-x\\" tabindex=\\"0\\" style=\\"left: 0px; width: 0px;\\"></div>
+</div>
+<div class=\\"ps__rail-y\\" style=\\"top: 0px; left: 0px;\\">
+   <div class=\\"ps__thumb-y\\" tabindex=\\"0\\" style=\\"top: 0px; height: 0px;\\"></div>
+</div>
 </main>
 </div>"
 `;