Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on route change, clear notifications #1149

Closed
jbibla opened this issue Aug 16, 2018 · 2 comments
Closed

on route change, clear notifications #1149

jbibla opened this issue Aug 16, 2018 · 2 comments
Assignees
@jbibla
Labels
high priority ❗

Comments

@jbibla
Copy link
Collaborator

jbibla commented Aug 16, 2018

the notifications can be pretty annoying. a simple improvement would be to remove them when the user changes routes.
@faboweb faboweb removed the discuss label Sep 4, 2018
@jbibla jbibla self-assigned this Oct 1, 2018
@faboweb faboweb assigned fedekunze and unassigned NodeGuy Oct 16, 2018
@faboweb
Copy link
Collaborator

faboweb commented Nov 6, 2018

Should we keep this, when we go for #1511 ?

@jbibla
Copy link
Collaborator Author

jbibla commented Nov 6, 2018 •
edited
Loading

i think reducing the use of this component is more important than clearing notifications on route changes.

@jbibla jbibla closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbibla jbibla

Labels
high priority ❗
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NodeGuy @faboweb @jbibla @fedekunze