Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more graceful failures #1511

Closed
jbibla opened this issue Nov 1, 2018 · 5 comments
Closed

more graceful failures #1511

jbibla opened this issue Nov 1, 2018 · 5 comments

Comments

@jbibla
Copy link
Collaborator

jbibla commented Nov 1, 2018

this may be covered by some other tickets and should be addressed in the sprint after gov1 ... but i wanted to log it as an example of an opportunity for improvement.

if you refresh voyager but voyager cannot find a good node to connect to this is what the user sees:

screen shot 2018-11-01 at 12 19 46 pm

  1. we don't need to notifications in the top right corner here

2a. a more graceful failure = do not dispay this full screen modal - but instead rely on the network-connectivity-bar to change states from green to orange and display 1 non-invasive popup that says "we're going to keep trying to connect to a good node for you. in the mean time, your experience may be degraded and we would recommend against making any transactions".

2b. part two of this should include disabling all submit buttons and some in app messaging about how maybe some of the data is not accurate.

  1. if for some reason we absolutely have to show this full screen modal - it should include an input so the user can add an IP if they know one.
@faboweb
Copy link
Collaborator

faboweb commented Nov 1, 2018

let's do it! thx for opening this issue

@faboweb faboweb added the split 🍌 issues that need to be split into several smaller issues with reduced scope label Nov 6, 2018
@faboweb faboweb self-assigned this Nov 6, 2018
@faboweb
Copy link
Collaborator

faboweb commented Nov 7, 2018

@jbibla in which cases would if for some reason we _absolutely_ have to show this full screen modal - it should include an input so the user can add an IP if they know one. happen?

@jbibla
Copy link
Collaborator Author

jbibla commented Nov 7, 2018

good question. i don't think we will end up in this situation - we can probably not use this at all.

@faboweb faboweb added epic and removed split 🍌 issues that need to be split into several smaller issues with reduced scope labels Nov 7, 2018
@faboweb
Copy link
Collaborator

faboweb commented Nov 27, 2018

Working on this in #1533

@faboweb
Copy link
Collaborator

faboweb commented Dec 11, 2018

Done in #1533

@faboweb faboweb closed this as completed Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants