Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename and clean up staking vuex modules #1381

Closed
jbibla opened this issue Sep 28, 2018 · 3 comments
Closed

rename and clean up staking vuex modules #1381

jbibla opened this issue Sep 28, 2018 · 3 comments

Comments

@jbibla
Copy link
Collaborator

jbibla commented Sep 28, 2018

it's not immediately obvious what these different modules are for or how they relate. i would propose renaming them and ensuring that the separation is necessary. this refactor should also include removing the concept of candidates from the code.

staking.js
validators.js
keybase.js // needs refactor
@faboweb
Copy link
Collaborator

faboweb commented Oct 1, 2018

as far as I know:
delegates -> all validators, would rename to validators
delegation -> staking related information, would rename to staking
validators -> current validator set, could be merged with delegates

@jbibla jbibla mentioned this issue Oct 26, 2018
2 tasks
@fedekunze fedekunze changed the title refactor vuex modules rename staking vuex modules Jan 3, 2019
@fedekunze fedekunze self-assigned this Jan 8, 2019
@fedekunze
Copy link
Contributor

the candidates.js module is very time inefficient. There're lots of duplicated/unnecessary for loops. Moving this to high priority as it's making the fee distribution vuex module more complex to implement

@fedekunze fedekunze changed the title rename staking vuex modules rename and clean up staking vuex modules Feb 21, 2019
@fedekunze fedekunze removed their assignment Mar 17, 2019
@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2019
@stale stale bot closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants