Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jordan/1283 language refactor #1383

Merged
merged 8 commits into from
Sep 29, 2018
Merged

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Sep 28, 2018

Closes #1283

Description:

@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #1383 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1383      +/-   ##
===========================================
- Coverage    95.16%   95.16%   -0.01%     
===========================================
  Files           83       83              
  Lines         1656     1654       -2     
  Branches        84       84              
===========================================
- Hits          1576     1574       -2     
  Misses          71       71              
  Partials         9        9
Impacted Files Coverage Δ
app/src/renderer/components/common/TmBalance.vue 100% <ø> (ø) ⬆️
...pp/src/renderer/components/staking/PageStaking.vue 100% <ø> (ø) ⬆️
...c/renderer/components/staking/TabMyDelegations.vue 36.17% <ø> (ø)
.../src/renderer/components/staking/TabValidators.vue 95.12% <ø> (ø) ⬆️
app/src/renderer/routes.js 100% <ø> (ø) ⬆️
...pp/src/renderer/components/common/TmOnboarding.vue 100% <ø> (ø) ⬆️
...pp/src/renderer/components/staking/LiValidator.vue 100% <100%> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 98.48% <100%> (ø) ⬆️
app/src/renderer/components/wallet/PageWallet.vue 86.84% <100%> (-0.66%) ⬇️
...rc/renderer/components/staking/DelegationModal.vue 100% <100%> (ø)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. We should open an issue to change what's left

@fedekunze fedekunze merged commit 0a5b914 into develop Sep 29, 2018
@fedekunze fedekunze deleted the jordan/1283-language-refactor branch September 29, 2018 22:29
@jbibla
Copy link
Collaborator Author

jbibla commented Sep 30, 2018

already did! #1381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants