Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve notification on no node found situation #1532

Closed
faboweb opened this issue Nov 7, 2018 · 6 comments
Closed

Improve notification on no node found situation #1532

faboweb opened this issue Nov 7, 2018 · 6 comments
Assignees
@faboweb
Labels
design-work-needed 🎨 issues that require design work before development high priority ❗

Comments

@faboweb
Copy link
Collaborator

faboweb commented Nov 7, 2018 •
edited
Loading

In the case of no connection:
do not dispay the full screen modal - but instead rely on the network-connectivity-bar to change states from green to orange and display 1 non-invasive popup that says "we're going to keep trying to connect to a good node for you. in the mean time, your experience may be degraded and we would recommend against making any transactions".

also: prevent notification popup spam like here:
screen shot 2018-11-01 at 12 19 46 pm
@faboweb faboweb added design-work-needed 🎨 issues that require design work before development high priority ❗ labels Nov 7, 2018
@faboweb faboweb mentioned this issue Nov 7, 2018
Closed
@NodeGuy
Copy link
Contributor

NodeGuy commented Nov 7, 2018

Duplicate of #1511.

@NodeGuy NodeGuy closed this as completed Nov 7, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Nov 7, 2018

This is split out from that issue.

@faboweb faboweb reopened this Nov 7, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Nov 8, 2018

Oh, sorry.

@faboweb
Copy link
Collaborator Author

faboweb commented Nov 20, 2018

Change naming to "Node is not reachable"
Add option to retry or use mocked version

@faboweb faboweb removed the discuss label Nov 20, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Nov 27, 2018

Working on this in #1533

@faboweb faboweb assigned faboweb and unassigned jbibla Nov 27, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Dec 11, 2018

Done in #1533

@faboweb faboweb closed this as completed Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faboweb faboweb

Labels
design-work-needed 🎨 issues that require design work before development high priority ❗
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NodeGuy @faboweb @jbibla