Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove session sign in/up for read-only purposes #1718

Closed
11 tasks
fedekunze opened this issue Dec 7, 2018 · 6 comments · Fixed by #1954
Closed
11 tasks

Remove session sign in/up for read-only purposes #1718

fedekunze opened this issue Dec 7, 2018 · 6 comments · Fixed by #1954
Assignees
@fedekunze
Labels
epic split 🍌 issues that need to be split into several smaller issues with reduced scope

Comments

@fedekunze
Copy link
Contributor

fedekunze commented Dec 7, 2018 •
edited
Loading

Often I might open Voyager just to view state / check if I've received a transaction, for which I will never need my password (or Ledger).

Originally posted by @cwgoes in #1638 (comment)

Scope:
Part 1: "explorer mode"

  • Remove balance header
  • Hide my delegations
  • Hide transactions
  • Hide wallet
  • Opening action modal points to sign in
  • Hide pref page
  • disable routes (redirect to session page)

Part 2:

  • Disable analytics
  • Start in "explorer mode"
  • Add sign in button
  • Sign out brings you to "explorer mode"
@fedekunze fedekunze mentioned this issue Dec 7, 2018
Closed
@fedekunze fedekunze self-assigned this Jan 8, 2019
@fedekunze fedekunze removed the discuss label Jan 8, 2019
@faboweb faboweb added the discuss label Jan 8, 2019
@faboweb faboweb assigned faboweb and fedekunze and unassigned fedekunze and faboweb Jan 15, 2019
@sabau
Copy link
Contributor

sabau commented Jan 16, 2019

I commented/removed the: show balance if user hasBalance logic from the TmPage PR, one conflict less 🎉

@jbibla
Copy link
Collaborator

jbibla commented Jan 16, 2019

in "explorer mode": Hide transactions

we discussed hiding the personal transactions tab but not the "all transactions" tab (which doesn't exist yet)

in "explorer mode": Hide pref page

i don't think we should hide this page, i think we should ask the user to sign up / sign in to save preferences.

in "explorer mode": Disable analytics

why?

Sign out brings you to "explorer mode"

we're going to need a home page 😄

@faboweb
Copy link
Collaborator

faboweb commented Jan 16, 2019

in "explorer mode": Disable analytics

Because the user isn't able to opt in. But we can just always collect when the user allows "cookies and stuff".

in "explorer mode": Hide pref page

ok, then hide user specific stuff like analytics

in "explorer mode": Hide transactions

yes but let's hide the transactions until we have "all transactions"

@fedekunze fedekunze mentioned this issue Jan 18, 2019
Closed
2 tasks
@jbibla
Copy link
Collaborator

jbibla commented Jan 22, 2019

Because the user isn't able to opt in.

i think we need to default to some amount of analytics. i am very open to letting users opt out. re: cookies - we should investigate the requirements here more closely.

ok, then hide user specific stuff like analytics

i think our approach should be to hide as little as possible - but prompt people to sign in to save their settings (in the case of the pref page).

yes but let's hide the transactions until we have "all transactions"

sure sounds good!

@jbibla jbibla mentioned this issue Jan 25, 2019
Closed
@faboweb faboweb mentioned this issue Jan 25, 2019
Closed
3 tasks
@faboweb faboweb removed the discuss label Jan 29, 2019
@faboweb
Copy link
Collaborator

faboweb commented Jan 29, 2019

Maybe split:

  • start in explorer mode
  • add signin / signout

@fedekunze fedekunze added the split 🍌 issues that need to be split into several smaller issues with reduced scope label Jan 29, 2019
This was referenced Jan 31, 2019
Merged
Merged
@fedekunze
Copy link
Contributor Author

updated description with the 2 parts and their scope of work

@fedekunze fedekunze mentioned this issue Feb 11, 2019
Merged
2 tasks
@faboweb faboweb mentioned this issue Feb 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
epic split 🍌 issues that need to be split into several smaller issues with reduced scope
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fedekunze/1718 remove session pt 2 luniehq/lunie
4 participants
@sabau @faboweb @jbibla @fedekunze