fedekunze/1718 remove session pt 2 #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
January 31, 2019 14:19
added 3 commits
February 12, 2019 11:05
…kunze/1718-remove-session-pt-2 pull develop
|
@faboweb added screenshots here |
Codecov Report
@@ Coverage Diff @@
## develop #1954 +/- ##
===========================================
- Coverage 95.51% 94.86% -0.66%
===========================================
Files 121 121
Lines 2611 2627 +16
Branches 121 123 +2
===========================================
- Hits 2494 2492 -2
- Misses 108 126 +18
Partials 9 9
|
…mos/voyager into fedekunze/1718-explorer-mode fix conflict changelog
…kunze/1718-remove-session-pt-2
…om/cosmos/voyager into fedekunze/1718-remove-session-pt-2
…om/cosmos/voyager into fedekunze/1718-remove-session-pt-2
|
apparently there's no way to test the functionality of an anonymous function passed as parameter (see jestjs/jest#6390) |
faboweb
reviewed
Feb 14, 2019
| }, | ||
| back() { | ||
| if (!this.lastPage) return | ||
| this.$store.commit(`pauseHistory`, true) |
faboweb
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1718
NOTE: depends on #1916
Screenshots:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer