Fabo/1171 Validator Profile #1317
Conversation
| @@ -247,7 +247,6 @@ export default { | |||
| } | |||
| }, | |||
| validatorTitle(validator) { | |||
There was a problem hiding this comment.
shouldn't this be a computed property instead as opposed to a method?
There was a problem hiding this comment.
Will probably remove it
| span.validator-profile__status(v-bind:class="statusColor" v-tooltip.top="status") | ||
| .validator-profile__header__name__title {{ validatorTitle(validator) }} | ||
| //- TODO replace with address component when ready | ||
| anchor-copy.validator-profile__header__name__address(:value="validator.owner" :label="shortAddress(validator.owner)") |
There was a problem hiding this comment.
Let's display the full address here, we have enough space to show it
There was a problem hiding this comment.
no i don't think that's a good idea. the validator profile is like a blown up version of the validator Li - i want to keep it for consistency and familiarity. the form below (validator details) should show the full address.
There was a problem hiding this comment.
@jbibla we're not showing the address below, only the pub_key
| .column | ||
| div.validator-profile__status-and-title | ||
| span.validator-profile__status(v-bind:class="statusColor" v-tooltip.top="status") | ||
| .validator-profile__header__name__title {{ validatorTitle(validator) }} |
There was a problem hiding this comment.
Can we get rid of the ... - (address) please ? I don't see a point on keeping it since we're already showing the validator's owner address
There was a problem hiding this comment.
no i don't think that's a good idea. the validator profile is like a blown up version of the validator Li - i want to keep it for consistency and familiarity. the form below (validator details) should show the full address.
There was a problem hiding this comment.
Fede meant the suffix after the title. For consistency with the LiValidator I removed it.
There was a problem hiding this comment.
According to the designs we shouldn't be showing the - (address) ...
| dd n/a | ||
| dl.info_dl | ||
| dt Details | ||
| dd.info_dl__text-box {{validator.description.details || 'n/a'}} |
There was a problem hiding this comment.
@faboweb I think we should definitely add the validator website on another box as well
There was a problem hiding this comment.
also let's change all the [do-not-modify] cases to n/a
There was a problem hiding this comment.
i don't think we should add the website as a form element in the second box. the designs have an icon for visiting the website beside the moniker.
There was a problem hiding this comment.
I don't think an icon alone is self explanatory. We can have both. I will add it and we can remove it later again.
There was a problem hiding this comment.
the designs have an icon for visiting the website beside the moniker.
Ohh that's the website ? can we change it for this icon then ?
Codecov Report
@@ Coverage Diff @@
## develop #1317 +/- ##
===========================================
+ Coverage 97.34% 97.37% +0.02%
===========================================
Files 82 82
Lines 1622 1639 +17
Branches 75 84 +9
===========================================
+ Hits 1579 1596 +17
Misses 37 37
Partials 6 6
|
|
Updated screenshot |
…os/voyager into fabo/1171-validator-profile
Closes #1171
New:
❤️ Thank you!