Fabo/1294 undelegation modal #1367

faboweb · 2018-09-26T16:56:34Z

Closes #1294
Closes #1397
Closes #1325

Missing:

E2E tests

❤️ Thank you!

…hem.

jbibla

looooks real goood.

fedekunze

Left comments on modal and submitDelegation

app/src/renderer/components/staking/ModalUnstake.vue

app/src/renderer/components/staking/PageValidator.vue

jbibla · 2018-09-27T12:34:05Z

@fedekunze i appreciate all of your ux suggestions! 💪

…tion-modal

codecov · 2018-09-28T16:55:55Z

Codecov Report

Merging #1367 into develop will increase coverage by 0.15%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1367      +/-   ##
===========================================
+ Coverage    94.79%   94.95%   +0.15%     
===========================================
  Files           84       85       +1     
  Lines         1673     1703      +30     
  Branches        83       87       +4     
===========================================
+ Hits          1586     1617      +31     
+ Misses          78       77       -1     
  Partials         9        9

Impacted Files	Coverage Δ
app/src/renderer/components/common/TmModal.vue	`100% <ø> (ø)`	⬆️
...pp/src/renderer/components/staking/LiValidator.vue	`100% <100%> (ø)`	⬆️
.../src/renderer/components/staking/PageValidator.vue	`98.76% <100%> (+0.28%)`	⬆️
.../renderer/components/staking/UndelegationModal.vue	`100% <100%> (ø)`
...rc/renderer/components/staking/DelegationModal.vue	`100% <100%> (ø)`	⬆️
app/src/renderer/vuex/getters.js	`96.77% <0%> (+3.22%)`	⬆️

fedekunze

Looking good. I left some comments on the CannotUnstake modal and class color

app/src/renderer/components/staking/LiValidator.vue

app/src/renderer/components/staking/PageValidator.vue

test/unit/specs/components/staking/__snapshots__/LiValidator.spec.js.snap

test/unit/specs/components/staking/__snapshots__/TabValidators.spec.js.snap

faboweb · 2018-10-01T09:40:19Z

test/e2e/staking.js

+    t.end()
+  })
+
+  t.test(`Unstake`, async t => {


👍 @NodeGuy

Conflicts: app/src/renderer/components/staking/LiValidator.vue app/src/renderer/components/staking/PageValidator.vue test/unit/specs/components/staking/PageValidator.spec.js test/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap

…app/src/renderer/components/staking/LiValidator.vue app/src/renderer/components/staking/PageValidator.vue test/unit/specs/components/staking/PageValidator.spec.js test/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap

fedekunze

utACK. Left some minor comments. Please proceed with merging in case you feel that they are not relevant for this PR

fedekunze · 2018-10-01T12:21:46Z

app/src/renderer/components/staking/UndelegationModal.vue

+
+    //- To
+    tm-form-group.delegation-modal-form-group(
+      field-id='to' field-label='To')


I'd change the label to say Wallet or Your Wallet (something like that)

what do you mean?

@jbibla because you always unbond to your address (i.e your wallet), so imo there's no point on having a To label

We just had an offline convo: To, could also be used for redelegations (undelegate to another Validator) in the future. Currently it isn't.

test/unit/helpers/console_error_throw.js

test/unit/specs/components/staking/UndelegationModal.spec.js

fedekunze · 2018-10-02T11:55:04Z

app/src/renderer/components/staking/LiValidator.vue

-    // add .green .yellow or .red class to this span to trigger inidication by color
-    span {{ slashes }}
+    .li-validator__value.your-votes
+      span {{ yourVotes }}


@faboweb we should replicate the same condition being used in PageValidator.vue with the myBonds() function to show < 0.01 when the bond amount is low

fedekunze · 2018-10-02T12:06:09Z

test/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap

@@ -206,7 +206,7 @@ exports[`PageValidator has the expected html structure 1`] = `
              My Bonded Steak
            </dt>
            <dd>
-              &lt; 0.01
+              0.00


is this supposed to be 0 ?

It was, I changed it now to something show another value.

…tion-modal

fedekunze

Tested the functionality and a couple of things are failing for me:

Modal Undelegation  

Click outside and x (close) button not working - DONE
Amount label in wrong position 
Undelegate button is not disabled when amount = 0  - DONE
Can’t increase amount to undelegate (add the number) when 0 < bond < 1 
Modal not closing after successful undelegation   - DONE
Denom (eg. stake) not displayed in the amount input field (see delegation modal) - DONE

LiValidator 

Status color dot covers numbers > 9

PageValidator

Error Undelegation modal not displaying - DONE

fedekunze · 2018-10-04T09:21:36Z

Undelegation works and the transaction is displayed correctly in the tx history 👍

jbibla · 2018-10-04T14:10:52Z

nice QA @fedekunze !

addressed logic, opening issues for remaining UI comments

fedekunze · 2018-10-05T16:59:05Z

Should be good to go now

Voyager Bot and others added 4 commits September 26, 2018 15:23

copied staking modal

b22ee0a

unstaking working

defec9f

copied unstake modal spec

3a72ac8

Copy ModalUnstake tests in PageValidator.spec.js and start adapting t…

f06915c

…hem.

faboweb requested review from NodeGuy and nylira as code owners September 26, 2018 16:56

Merge branch 'develop' into fabo/1294-undelegation-modal

fdc3f5d

jbibla previously approved these changes Sep 26, 2018

View reviewed changes

fedekunze suggested changes Sep 26, 2018

View reviewed changes

Merge branch 'develop' into fabo/1294-undelegation-modal

4e47112

Make all unit tests pass for unstaking.

4bff2d2

NodeGuy dismissed jbibla’s stale review via 4bff2d2 September 28, 2018 01:30

Voyager Bot added 7 commits September 28, 2018 17:24

fix status color missing

f38db9f

Merge remote-tracking branch 'origin/develop' into fabo/1294-undelega…

5a5df5d

…tion-modal

added ux updates to modal unstake

05a4324

changelog

2740908

linted

0a55983

fixed tests

885ed25

fixed snapshots

2e55de3

fedekunze reviewed Sep 28, 2018

View reviewed changes

David Braun and others added 4 commits September 30, 2018 20:00

Add E2E test for unstaking.

7bea969

fix less then 0.01 displaying

47d6078

reverted disabling of unstake button

d52ea53

fixed snapshot

2abd961

faboweb commented Oct 1, 2018

View reviewed changes

test/e2e/staking.js Outdated

t.end()

})

t.test(`Unstake`, async t => {

Copy link

Collaborator Author

faboweb Oct 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @NodeGuy

faboweb changed the title ~~WIP: Fabo/1294 undelegation modal~~ Fabo/1294 undelegation modal Oct 1, 2018

Voyager Bot added 3 commits October 1, 2018 13:42

fix e2e tests

43f5d88

fix snapshot

86a9fe0

fix naming

f157c9e

fedekunze previously approved these changes Oct 1, 2018

View reviewed changes

uncommented console error file

d7693f7

faboweb dismissed fedekunze’s stale review via d7693f7 October 1, 2018 13:31

faboweb and others added 2 commits October 2, 2018 12:18

Merge branch 'develop' into fabo/1294-undelegation-modal

e9e5517

merged develop

685c886

fedekunze reviewed Oct 2, 2018

View reviewed changes

fedekunze mentioned this pull request Oct 2, 2018

PageValidator Bonded stake ≠ than the one displayed in LiValidator #1397

Closed

Merge remote-tracking branch 'origin/develop' into fabo/1294-undelega…

39a96dc

…tion-modal

faboweb mentioned this pull request Oct 2, 2018

Release #1357

Closed

Voyager Bot and others added 4 commits October 4, 2018 10:18

fixed

0374842

add a delegation to the validator page snapshot

40fdadd

fixed merge conflicts

6f30319

Merge branch 'develop' into fabo/1294-undelegation-modal

99032b0

fedekunze previously requested changes Oct 4, 2018

View reviewed changes

faboweb mentioned this pull request Oct 4, 2018

Can’t increase amount to undelegate (add the number) when 0 < bond < 1  #1409

Closed

fedekunze mentioned this pull request Oct 4, 2018

Add status dots on the validator Li component #1325

Closed

Federico Kunze and others added 3 commits October 5, 2018 18:01

close signal, disable button, denom and tests

6fe71a6

fix unit tests

ca2a054

Merge branch 'develop' into fabo/1294-undelegation-modal

aed26e5

NodeGuy approved these changes Oct 5, 2018

View reviewed changes

NodeGuy merged commit fbd3d51 into develop Oct 5, 2018

NodeGuy deleted the fabo/1294-undelegation-modal branch October 5, 2018 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fabo/1294 undelegation modal #1367

Fabo/1294 undelegation modal #1367

faboweb commented Sep 26, 2018 •

edited by fedekunze

Loading

jbibla left a comment

fedekunze left a comment

jbibla commented Sep 27, 2018

codecov bot commented Sep 28, 2018 •

edited

Loading

fedekunze left a comment

faboweb Oct 1, 2018

fedekunze left a comment •

edited

Loading

fedekunze Oct 1, 2018

jbibla Oct 1, 2018

fedekunze Oct 1, 2018

faboweb Oct 1, 2018

fedekunze Oct 2, 2018

fedekunze Oct 2, 2018

faboweb Oct 4, 2018

fedekunze left a comment •

edited

Loading

fedekunze commented Oct 4, 2018

jbibla commented Oct 4, 2018

fedekunze commented Oct 5, 2018

Fabo/1294 undelegation modal #1367

Fabo/1294 undelegation modal #1367

Conversation

faboweb commented Sep 26, 2018 • edited by fedekunze Loading

jbibla left a comment

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment

jbibla commented Sep 27, 2018

codecov bot commented Sep 28, 2018 • edited Loading

Codecov Report

fedekunze left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedekunze left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedekunze left a comment • edited Loading

Choose a reason for hiding this comment

fedekunze commented Oct 4, 2018

jbibla commented Oct 4, 2018

fedekunze commented Oct 5, 2018

faboweb commented Sep 26, 2018 •

edited by fedekunze

Loading

codecov bot commented Sep 28, 2018 •

edited

Loading

fedekunze left a comment •

edited

Loading

fedekunze left a comment •

edited

Loading