Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedekunze/1436 gov endpoints and modules #1463

Merged
merged 29 commits into from
Oct 19, 2018
Merged

Conversation

fedekunze
Copy link
Contributor

Closes #1436

Description:

❤️ Thank you!

@faboweb
Copy link
Collaborator

faboweb commented Oct 16, 2018

Note: vuex module was not part of the scope of the issue.

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #1463 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1463      +/-   ##
===========================================
+ Coverage    96.73%   96.81%   +0.08%     
===========================================
  Files           89       91       +2     
  Lines         1682     1725      +43     
  Branches        77       77              
===========================================
+ Hits          1627     1670      +43     
  Misses          45       45              
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/vuex/store.js 100% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/governance/votes.js 100% <100%> (ø)
app/src/renderer/connectors/lcdClient.js 92.1% <100%> (+1.48%) ⬆️
app/src/renderer/vuex/getters.js 94.44% <100%> (+0.32%) ⬆️
...p/src/renderer/vuex/modules/governance/deposits.js 100% <100%> (ø)
.../src/renderer/vuex/modules/governance/proposals.js 100% <100%> (ø)
app/src/renderer/connectors/lcdClientMock.js 99.23% <100%> (+0.03%) ⬆️

@fedekunze fedekunze changed the title WIP: fedekunze/1436 gov endpoints fedekunze/1436 gov endpoints Oct 19, 2018
@fedekunze fedekunze changed the title fedekunze/1436 gov endpoints fedekunze/1436 gov endpoints and modules Oct 19, 2018
@NodeGuy NodeGuy merged commit 0ffcab8 into develop Oct 19, 2018
@NodeGuy NodeGuy deleted the fedekunze/1436-gov-endpoints branch October 19, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add governance endpoints to lcdClient
3 participants