Fixed running of local testnet by creating workaround for SDK bug. #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeGuy
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1492 +/- ##
===========================================
+ Coverage 96.92% 96.93% +<.01%
===========================================
Files 91 91
Lines 1725 1727 +2
Branches 77 77
===========================================
+ Hits 1672 1674 +2
Misses 43 43
Partials 10 10
|
NodeGuy
changed the title
jbibla
approved these changes
Oct 25, 2018
|
Lol that was it ? |
|
the sdk returns a string but we need it to be an array |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround for cosmos/cosmos-sdk#2470 by converting string
"[]"to list[].Closes #1487
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer