fedekunze/1409 fix bond amount #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2018 15:38
added 2 commits
October 29, 2018 15:45
Codecov Report
@@ Coverage Diff @@
## develop #1498 +/- ##
===========================================
- Coverage 96.96% 96.96% -0.01%
===========================================
Files 92 92
Lines 1712 1711 -1
Branches 77 77
===========================================
- Hits 1660 1659 -1
Misses 43 43
Partials 9 9
|
|
can't you use the mocked testnet for this? |
faboweb
added
blocked ✋
…osmos/voyager into fedekunze/1409-fix-bond-amount
jbibla
previously approved these changes
Nov 1, 2018
|
codecov says the tests have decreased by |
|
In total but the touched code has full coverage. This is why the total coverage is not a required check. |
|
@faboweb why did you reject my approval instead of merging? |
|
This happens automatically when you merge in new code. This wasn't the disapprove your approval. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1409
Description:
Note, I can't test it since I can't receive tokens on the local-testnet due to bech32 prefix issues
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer