-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jordan/1496 misc fixes #1499
Jordan/1496 misc fixes #1499
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1499 +/- ##
========================================
Coverage 96.96% 96.96%
========================================
Files 92 92
Lines 1712 1712
Branches 77 77
========================================
Hits 1660 1660
Misses 43 43
Partials 9 9
|
.top {{ validator.description.moniker }} | ||
short-bech32(:address="validator.operator_address") | ||
short-bech32(:address="validator.pub_key") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure we need to show the pub_key. In the SDK the pub_key can change but the operator_address can't as far as I know. I also don't know if the user at any point needs to know the pub_key. Is that correct @cwgoes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, the operator address is the important part here, not the public key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah interesting! does the user delegate to the pub_key
or the operator_address
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah interesting! does the user delegate to the pub_key or the operator_address?
No, you only delegate to the operator address (validatorAddr)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok cool. then i'll revert back to operator_address
Closes #1496
Description:
❤️ Thank you!
CHANGELOG.md
with issue # and GitHub usernameFiles changed
in the github PR explorer