Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jordan/1496 misc fixes #1499

Merged
merged 10 commits into from
Oct 31, 2018
Merged

Jordan/1496 misc fixes #1499

merged 10 commits into from
Oct 31, 2018

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Oct 29, 2018

Closes #1496

Description:

  • display validator pub_key instead of operator_address
  • no longer destructuring tm-data-error
  • display first column of table filters
  • styling improvements

screen shot 2018-10-29 at 1 47 10 pm

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #1499 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #1499   +/-   ##
========================================
  Coverage    96.96%   96.96%           
========================================
  Files           92       92           
  Lines         1712     1712           
  Branches        77       77           
========================================
  Hits          1660     1660           
  Misses          43       43           
  Partials         9        9
Impacted Files Coverage Δ
...pp/src/renderer/components/staking/LiValidator.vue 96.15% <ø> (ø) ⬆️
app/src/renderer/components/common/TmBalance.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/staking/PanelSort.vue 100% <ø> (ø) ⬆️
...c/renderer/components/staking/TabMyDelegations.vue 88.88% <ø> (ø) ⬆️
...pp/src/renderer/components/staking/PageStaking.vue 100% <ø> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 98.8% <100%> (ø) ⬆️

.top {{ validator.description.moniker }}
short-bech32(:address="validator.operator_address")
short-bech32(:address="validator.pub_key")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we need to show the pub_key. In the SDK the pub_key can change but the operator_address can't as far as I know. I also don't know if the user at any point needs to know the pub_key. Is that correct @cwgoes ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, the operator address is the important part here, not the public key

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah interesting! does the user delegate to the pub_key or the operator_address?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah interesting! does the user delegate to the pub_key or the operator_address?

No, you only delegate to the operator address (validatorAddr)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool. then i'll revert back to operator_address

@NodeGuy NodeGuy merged commit c18dbb0 into develop Oct 31, 2018
@NodeGuy NodeGuy deleted the jordan/1496-val-address branch October 31, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misc. staking fixes and imrprovements
4 participants