Fabo/1500 fixed optimistic updates #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2018 17:32
Codecov Report
@@ Coverage Diff @@
## develop #1535 +/- ##
==========================================
- Coverage 96.41% 96.4% -0.01%
==========================================
Files 97 97
Lines 1811 1810 -1
Branches 86 86
==========================================
- Hits 1746 1745 -1
Misses 55 55
Partials 10 10
|
fedekunze
reviewed
Nov 7, 2018
| @@ -255,4 +256,50 @@ describe(`Module: Delegations`, () => { | |||
| await store.dispatch(`updateDelegates`) | |||
| expect(store.state.delegation.committedDelegates).toBeTruthy() | |||
| }) | |||
|
|
|||
| it.only(`should update the atoms on a delegation optimistically`, async () => { | |||
added 2 commits
November 7, 2018 17:39
|
needs to update the snapshots |
added 3 commits
November 8, 2018 14:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1500
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer