Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedekunze/1578 e2e submit proposals & staking parameters #1671

Merged
merged 7 commits into from
Dec 3, 2018

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Nov 29, 2018

Closes #1578
Closes #1672

Description:

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #1671 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1671   +/-   ##
========================================
  Coverage    97.71%   97.71%           
========================================
  Files          101      101           
  Lines         2056     2056           
  Branches        92       92           
========================================
  Hits          2009     2009           
  Misses          36       36           
  Partials        11       11
Impacted Files Coverage Δ
.../src/renderer/components/staking/TabParameters.vue 100% <ø> (ø) ⬆️

@fedekunze fedekunze changed the title WIP: fedekunze/1578 e2e submit proposals WIP: fedekunze/1578 e2e submit proposals & staking parameters Nov 30, 2018
@fedekunze fedekunze changed the title WIP: fedekunze/1578 e2e submit proposals & staking parameters fedekunze/1578 e2e submit proposals & staking parameters Nov 30, 2018
@fedekunze fedekunze requested a review from jbibla November 30, 2018 11:26
Copy link
Collaborator

@faboweb faboweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one comment, looks very good. Thx

test/e2e/delegation.js Show resolved Hide resolved
@faboweb faboweb merged commit 9817665 into develop Dec 3, 2018
@faboweb faboweb deleted the fedekunze/1578-e2e-submit-proposals branch December 3, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add staking parameters to e2e test Add submit proposal to E2E tests
2 participants