fedekunze/1648 gov params tab #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1678 +/- ##
===========================================
+ Coverage 97.7% 97.72% +0.01%
===========================================
Files 101 102 +1
Lines 2052 2062 +10
Branches 92 92
===========================================
+ Hits 2005 2015 +10
Misses 36 36
Partials 11 11
|
fedekunze
changed the title
jbibla
reviewed
Dec 3, 2018
jbibla
reviewed
Dec 3, 2018
jbibla
reviewed
Dec 3, 2018
jbibla
reviewed
Dec 3, 2018
jbibla
previously requested changes
Dec 3, 2018
| Loose {{ parameters.parameters.bond_denom }} | ||
| Loose | ||
| {{ | ||
| stakingParameters.parameters.bond_denom |
There was a problem hiding this comment.
yeah if there's an error to display the params then the title won't be displayed completely
There was a problem hiding this comment.
when would it be better to show bondingDenom over stakingParameters.parameters.bond_denom?
There was a problem hiding this comment.
idk, is there a case on which the bondingDenom is not set? maybe we should check that and remove the hardcoded values from parameters everywhere
There was a problem hiding this comment.
yes! can you create an issue?
Co-Authored-By: fedekunze <[email protected]>
Co-Authored-By: fedekunze <[email protected]>
Co-Authored-By: fedekunze <[email protected]>
Co-Authored-By: fedekunze <[email protected]>
Co-Authored-By: fedekunze <[email protected]>
Co-Authored-By: fedekunze <[email protected]>
Co-Authored-By: fedekunze <[email protected]>
Co-Authored-By: fedekunze <[email protected]>
Co-Authored-By: fedekunze <[email protected]>
faboweb
reviewed
Dec 4, 2018
faboweb
reviewed
Dec 4, 2018
Co-Authored-By: fedekunze <[email protected]>
Co-Authored-By: fedekunze <[email protected]>
Co-Authored-By: fedekunze <[email protected]>
jbibla
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1648
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer