sabau/1681-Modal proposal feedback #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix votingStartedAgo attribute from voting_start_block to voting_start_time ModalPropose: - error messages for title and description maxLength - error class enabled in form group if the data is not validated - short form methods for validators Signed-off-by: Karoly Albert Szabo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #1692 +/- ##
==========================================
- Coverage 97.71% 97.7% -0.01%
==========================================
Files 101 101
Lines 2056 2052 -4
Branches 92 92
==========================================
- Hits 2009 2005 -4
Misses 36 36
Partials 11 11
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #1692 +/- ##
==========================================
- Coverage 97.71% 97.7% -0.01%
==========================================
Files 101 101
Lines 2056 2052 -4
Branches 92 92
==========================================
- Hits 2009 2005 -4
Misses 36 36
Partials 11 11
|
jbibla
reviewed
Dec 4, 2018
jbibla
approved these changes
Dec 4, 2018
|
amazing, already the 2nd PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PageProposal:
ModalPropose:
Closes #1681
Contribute to #1690
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer