Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some css variables #1698

Merged
merged 4 commits into from
Dec 5, 2018
Merged

fixed some css variables #1698

merged 4 commits into from
Dec 5, 2018

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Dec 4, 2018

Closes #1696

Description:

  • fixed some borked css variables

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@jbibla jbibla requested review from faboweb and nylira as code owners December 4, 2018 21:30
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #1698 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1698   +/-   ##
========================================
  Coverage    97.72%   97.72%           
========================================
  Files          102      102           
  Lines         2062     2062           
  Branches        92       92           
========================================
  Hits          2015     2015           
  Misses          36       36           
  Partials        11       11
Impacted Files Coverage Δ
.../src/renderer/components/staking/PageValidator.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/TmBalance.vue 100% <ø> (ø) ⬆️
.../src/renderer/components/common/TmModalNoNodes.vue 100% <ø> (ø) ⬆️
...c/renderer/components/common/TmModalNodeHalted.vue 100% <ø> (ø) ⬆️
.../src/renderer/components/staking/TabParameters.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/staking/PanelSort.vue 100% <ø> (ø) ⬆️
...c/renderer/components/staking/TabMyDelegations.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/TmModal.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/ShortBech32.vue 100% <ø> (ø) ⬆️
...c/renderer/components/governance/TabParameters.vue 100% <ø> (ø) ⬆️
... and 3 more

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #1698 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1698   +/-   ##
========================================
  Coverage    97.74%   97.74%           
========================================
  Files          102      102           
  Lines         2080     2080           
  Branches        92       92           
========================================
  Hits          2033     2033           
  Misses          38       38           
  Partials         9        9
Impacted Files Coverage Δ
.../src/renderer/components/staking/PageValidator.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/TmBalance.vue 100% <ø> (ø) ⬆️
.../renderer/components/governance/TableProposals.vue 100% <ø> (ø) ⬆️
...c/renderer/components/common/TmModalNodeHalted.vue 100% <ø> (ø) ⬆️
.../src/renderer/components/staking/TabParameters.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/staking/PanelSort.vue 100% <ø> (ø) ⬆️
...c/renderer/components/staking/TabMyDelegations.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/TmModal.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/ShortBech32.vue 100% <ø> (ø) ⬆️
...c/renderer/components/governance/TabParameters.vue 100% <ø> (ø) ⬆️
... and 2 more

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit 5f2e050 into develop Dec 5, 2018
@fedekunze fedekunze deleted the jordan/1696-css-vars branch December 5, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a bunch of broken css variables
3 participants