Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/1687-handle state decrption error #1699

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Fabo/1687-handle state decrption error #1699

merged 2 commits into from
Dec 5, 2018

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Dec 5, 2018

Closes #1687

Description:

❤️ Thank you!

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@faboweb faboweb requested a review from nylira as a code owner December 5, 2018 10:40
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #1699 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1699      +/-   ##
===========================================
+ Coverage    97.69%   97.69%   +<.01%     
===========================================
  Files          102      102              
  Lines         2080     2085       +5     
  Branches        92       92              
===========================================
+ Hits          2032     2037       +5     
  Misses          38       38              
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/vuex/store.js 100% <100%> (ø) ⬆️

@codecov
Copy link

codecov bot commented Dec 5, 2018 •
edited
Loading

Codecov Report

Merging #1699 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1699      +/-   ##
===========================================
+ Coverage    97.69%   97.69%   +<.01%     
===========================================
  Files          102      102              
  Lines         2080     2085       +5     
  Branches        92       92              
===========================================
+ Hits          2032     2037       +5     
  Misses          38       38              
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/vuex/store.js 100% <100%> (ø) ⬆️

fedekunze
fedekunze approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, I think this may fix my test errors on #1689

@fedekunze fedekunze merged commit 2f5a9f1 into develop Dec 5, 2018
@fedekunze fedekunze deleted the fabo/1687-handel-state-decryption-error branch December 5, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@nylira nylira Awaiting requested review from nylira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Malformed UTF-8 data
2 participants
@faboweb @fedekunze