Added undelegation transactions to TabMyDelegation #1743

sabau · 2018-12-12T17:45:15Z

Description

Added the list of transactions related to unbound.
Changed the title of the unbounding validartor list
added title to the Active Validators list
refactored a the modifiers in the delegations store
updated e2e test

Graphical suggestions are really welcome :) I personally don't like the solution I pourpose here, but was a starting point to have the data ready by recycling the view.

An idea I had was to make the transacitons part of the table, so every transacitons will appear as subrow of the unbounding validator (eventually collapsable)

Closes #1387

Note

as this PR grew enough I think the redelegation will be a separate one

We should create a separate PR for that
❤️ Thank you!

Added entries in CHANGELOG.md with issue # and GitHub username
Reviewed Files changed in the github PR explorer

- setUnbondingDelegations now takes as input an array instead of doing that from outside Signed-off-by: Karoly Albert Szabo <[email protected]>

Signed-off-by: Karoly Albert Szabo <[email protected]>

codecov · 2018-12-13T11:48:21Z

Codecov Report

Merging #1743 into develop will decrease coverage by 0.05%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop    #1743      +/-   ##
===========================================
- Coverage     97.7%   97.65%   -0.06%     
===========================================
  Files          102      102              
  Lines         2093     2088       -5     
  Branches        93       93              
===========================================
- Hits          2045     2039       -6     
- Misses          39       40       +1     
  Partials         9        9

Impacted Files	Coverage Δ
app/src/renderer/vuex/modules/delegation.js	`100% <100%> (ø)`	⬆️
...c/renderer/components/staking/TabMyDelegations.vue	`93.75% <85.71%> (-6.25%)`	⬇️

codecov · 2018-12-13T11:48:21Z

Codecov Report

Merging #1743 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1743      +/-   ##
===========================================
- Coverage    95.07%   95.06%   -0.01%     
===========================================
  Files          122      123       +1     
  Lines         2982     2978       -4     
  Branches       128      126       -2     
===========================================
- Hits          2835     2831       -4     
  Misses         137      137              
  Partials        10       10

Impacted Files	Coverage Δ
.../src/renderer/components/staking/PageValidator.vue	`98.75% <ø> (ø)`	⬆️
...rer/components/transactions/TmLiAnyTransaction.vue	`100% <ø> (ø)`	⬆️
...rer/components/transactions/TmLiGovTransaction.vue	`100% <ø> (ø)`	⬆️
...c/renderer/components/staking/TabMyDelegations.vue	`100% <100%> (ø)`	⬆️
app/src/renderer/scripts/time.js	`100% <100%> (ø)`
app/src/renderer/vuex/modules/delegation.js	`100% <100%> (ø)`	⬆️
...rc/renderer/components/wallet/PageTransactions.vue	`93.75% <100%> (-0.85%)`	⬇️

Signed-off-by: Karoly Albert Szabo <[email protected]>

…remove it?) Signed-off-by: Karoly Albert Szabo <[email protected]>

fedekunze · 2018-12-13T13:37:19Z

See my comment on #1387 (comment). Let's rename the tab to My Validators and change the the Delegated steak header from the second section to Unbonded steak so we can get rid of the unbonding tx.

@faboweb what do you think ?

fedekunze · 2018-12-13T13:42:34Z

@sabau had a cool idea about making a dropdown on the LiValidator component so when you click it, it displays the unbonding txs from that validator. Maybe we can implement that on another PR ?

faboweb · 2018-12-13T13:53:09Z

@sabau had a cool idea about making a dropdown on the LiValidator component so when you click it, it displays the unbonding txs from that validator.

sounds cool. but let's maybe sketch it first.

app/src/renderer/components/staking/TabMyDelegations.vue

faboweb · 2018-12-13T13:56:19Z

test/e2e/delegation.js

@@ -62,11 +62,13 @@ test(`delegation`, async function(t) {
  t.test(`Stake`, async t => {
    let totalAtoms = (await app.client
      .$(`.header-balance .total-atoms h2`)
-      .getText()).split(`.`)[0] // 130.000...
+      .getText()).split(`.`)[0] // 30.000...


huh? why is it suddenly 100 less?

I think bonded atoms are not calculated in to the total atoms any longer. Needs to be fixed.

Exaclty this point I was uncertain on how this changed!

Still an issue?

fixed! 130.000 again

by replacing state.stuff = x with Vue.set(state, 'stuff', x)

jbibla · 2018-12-13T16:10:37Z

amazing work thank you @sabau!

@fedekunze we don't use the B (bond, unbond, bonding, unbonding) word, bud. 😉

making a dropdown on the LiValidator component so when you click it, it displays the unbonding txs from that validator.

very cool idea. i think i would prefer if we showed a link to the transaction on the transaction page as opposed to the actual tx component - but i can mock this up. either way, agreed - should be in a different PR.

Signed-off-by: Karoly Albert Szabo <[email protected]>

jbibla · 2018-12-14T15:37:53Z

app/src/renderer/components/staking/TabMyDelegations.vue

  data: () => ({
    bondInfo: `Validators you are currently bonded to`,
-    unbondInfo: `Your bonded validators in unbonding process`
+    unbondInfo: `Your bonded validators in unbonding process`,
+    unbondTransactions: `The transactions currently in unbouding period`


Suggested change

unbondTransactions: `The transactions currently in unbouding period`

unbondTransactions: `The transactions currently in unbonding period`

#no-bonding ;)

that's how the term is called, unbonding period. We agreed not to use bonding instead of delegation

let's just call it undelegation period?

Co-Authored-By: sabau <[email protected]>

faboweb · 2018-12-17T10:13:08Z

My proposal:

remove unbounding validators list
rename "unbounding transactions" to "undelegation transactions"
align transaction better with validator list
(- maybe have a better list component that fits better with the table layout of the validator list)
create a followup issue about redesigning this view for multiple undelegations per vaidator

fedekunze · 2018-12-17T10:17:38Z

My proposal:

remove unbonding delegations transactions
update LiValidator to show amount undelegated instead of delegated steak
rename My delegations to My validators, bc the first is inaccurate

fedekunze · 2018-12-17T10:18:36Z

I vote NoWithVeto on showing the undelegation txs

faboweb · 2018-12-17T10:24:10Z

app/src/renderer/vuex/modules/delegation.js

@@ -33,32 +33,28 @@ export default ({ node }) => {
      state.delegates = state.delegates.filter(c => c.id !== delegate)
    },
    setCommittedDelegation(state, { candidateId, value }) {
-      let committedDelegates = Object.assign({}, state.committedDelegates)
+      state.committedDelegates[candidateId] = value


this may be why the total atoms do not update. Vue has sometimes a problem with checking updates on objects. the getter in getters.js is probably only updating when state.committedDelegates changes but only the properties of this change. Try using Vue.set(state.committedDelegates, candidateId, value).

Oh no back then I missed this comment! I just fixed this

faboweb · 2018-12-17T10:26:12Z

I vote NoWithVeto on showing the undelegation txs

no such thing as NoWithVeto here ;)

faboweb · 2018-12-17T10:29:16Z

remove unbonding delegations transactions

why?

update LiValidator to show amount undelegated instead of delegated steak

also an option, but if the 2 list items are too similar it could be confusing

rename My delegations to My validators, bc the first is inaccurate

I disagree, it's not only about your validators but also about the undelegations.

sabau · 2018-12-18T09:17:44Z

I think we should discuss this synchronously. I would like to answer and all together agree on those two questions:

What do we want to offer in this section exactly?
What the user would need from this section and why?
- I think he needs to see a reaction from his delegation and undelegation actions (so the lists were OK)
- Probably he wants to know where he put his atoms
- I would like to know when I will have my atoms back
- How the list should look depends on what he can do, as for now he can do a single undelegation per validator = we have a single validator with a single amount a single period to show
  - but we are working in the direction of allowing several, so probably I would choose to work already in that direction, and show several amounts with different periods per validator or just not grouped at all but ordered from the most recent to the oldest

sabau · 2018-12-18T17:34:38Z

Show just 2 list with minimal redisign until Staking 2

Get rid of liValidator 2 (unbounding validator)
make it nice

In Staking 2 group per validator the txs and we will decide the details there

working on design in staking 2!

Signed-off-by: Karoly Albert Szabo <[email protected]>

app/src/renderer/components/staking/TabMyDelegations.vue

- adjust tests - dirty fix: shares and shares_amount have to be fixed in the mock Signed-off-by: Karoly Albert Szabo <[email protected]>

- fixed setCiommitedDelegation - vue caveats for updated props not seen Signed-off-by: Karoly Albert Szabo <[email protected]>

Signed-off-by: Karoly Albert Szabo <[email protected]>

app/src/renderer/components/staking/TabMyDelegations.vue

- add Time helper to get min_time for unbonding transactions - show only transactions in undelegation period Signed-off-by: Karoly Albert Szabo <[email protected]>

Added undelegation transactions to TabMyDelegation

4401156

sabau requested review from faboweb and nylira as code owners December 12, 2018 17:45

sabau added 2 commits December 13, 2018 12:15

simplified logic for modifiers, updated tests

f7a4dd5

- setUnbondingDelegations now takes as input an array instead of doing that from outside Signed-off-by: Karoly Albert Szabo <[email protected]>

Merge branch 'develop' into sabau/1387-unstaked-validator-list

e77c46b

sabau changed the title ~~[WIP] Added undelegation transactions to TabMyDelegation~~ Added undelegation transactions to TabMyDelegation Dec 13, 2018

update e2e test and fix modifier behaviour value in case of null

21c669d

Signed-off-by: Karoly Albert Szabo <[email protected]>

sabau added 3 commits December 13, 2018 13:10

test timeDiff

c18670a

Signed-off-by: Karoly Albert Szabo <[email protected]>

add header to first table, change title on second one (shall we just …

26503d6

…remove it?) Signed-off-by: Karoly Albert Szabo <[email protected]>

Merge branch 'develop' into sabau/1387-unstaked-validator-list

de37b21

faboweb reviewed Dec 13, 2018

View reviewed changes

app/src/renderer/components/staking/TabMyDelegations.vue Outdated Show resolved Hide resolved

faboweb reviewed Dec 13, 2018

View reviewed changes

sabau added 2 commits December 14, 2018 11:53

Fix Typo in TabMyDelegations.vue

3d7f14a

fix typo unbounding -> unbonding

0874826

Signed-off-by: Karoly Albert Szabo <[email protected]>

jbibla reviewed Dec 14, 2018

View reviewed changes

Update app/src/renderer/components/staking/TabMyDelegations.vue

0f715e4

Co-Authored-By: sabau <[email protected]>

faboweb reviewed Dec 17, 2018

View reviewed changes

Merge branch 'develop' into sabau/1387-unstaked-validator-list

d01bf8f

sabau added 3 commits December 19, 2018 10:51

Merge branch 'develop' into sabau/1387-unstaked-validator-list

5f26703

fix after discussion. Proper design will happen in staking-2

ba09735

Signed-off-by: Karoly Albert Szabo <[email protected]>

fix label for MuyDelegation spec

10df4d2

Signed-off-by: Karoly Albert Szabo <[email protected]>

faboweb reviewed Dec 29, 2018

View reviewed changes

app/src/renderer/components/staking/TabMyDelegations.vue Outdated Show resolved Hide resolved

sabau commented Dec 30, 2018

View reviewed changes

app/src/renderer/components/staking/TabMyDelegations.vue Outdated Show resolved Hide resolved

sabau added 4 commits January 2, 2019 16:57

remove unnecessary undelegatedValidators

e0d302e

- adjust tests - dirty fix: shares and shares_amount have to be fixed in the mock Signed-off-by: Karoly Albert Szabo <[email protected]>

Merge branch 'develop' into sabau/1387-unstaked-validator-list

4a97bea

fixes after merge ui

5a53daa

- fixed setCiommitedDelegation - vue caveats for updated props not seen Signed-off-by: Karoly Albert Szabo <[email protected]>

fix e2e delegation test total atoms

990c37e

Signed-off-by: Karoly Albert Szabo <[email protected]>

faboweb reviewed Jan 3, 2019

View reviewed changes

app/src/renderer/components/staking/TabMyDelegations.vue Show resolved Hide resolved

fix TabMyDelegations

2b5e6b1

- add Time helper to get min_time for unbonding transactions - show only transactions in undelegation period Signed-off-by: Karoly Albert Szabo <[email protected]>

faboweb approved these changes Jan 4, 2019

View reviewed changes

faboweb merged commit 8c78fe1 into develop Jan 4, 2019

faboweb deleted the sabau/1387-unstaked-validator-list branch January 4, 2019 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added undelegation transactions to TabMyDelegation #1743

Added undelegation transactions to TabMyDelegation #1743

sabau commented Dec 12, 2018 •

edited

Loading

codecov bot commented Dec 13, 2018

codecov bot commented Dec 13, 2018 •

edited

Loading

fedekunze commented Dec 13, 2018

fedekunze commented Dec 13, 2018 •

edited

Loading

faboweb commented Dec 13, 2018

faboweb Dec 13, 2018

faboweb Dec 13, 2018

sabau Dec 14, 2018 •

edited

Loading

faboweb Dec 29, 2018

sabau Jan 4, 2019

sabau Jan 4, 2019

jbibla commented Dec 13, 2018

jbibla Dec 14, 2018

faboweb Dec 17, 2018

fedekunze Dec 17, 2018

faboweb Dec 17, 2018

faboweb commented Dec 17, 2018 •

edited

Loading

fedekunze commented Dec 17, 2018

fedekunze commented Dec 17, 2018

faboweb Dec 17, 2018

sabau Jan 3, 2019

faboweb commented Dec 17, 2018

faboweb commented Dec 17, 2018

sabau commented Dec 18, 2018

sabau commented Dec 18, 2018

	unbondTransactions: `The transactions currently in unbouding period`
	unbondTransactions: `The transactions currently in unbonding period`

Added undelegation transactions to TabMyDelegation #1743

Added undelegation transactions to TabMyDelegation #1743

Conversation

sabau commented Dec 12, 2018 • edited Loading

Description

Note

codecov bot commented Dec 13, 2018

Codecov Report

codecov bot commented Dec 13, 2018 • edited Loading

Codecov Report

fedekunze commented Dec 13, 2018

fedekunze commented Dec 13, 2018 • edited Loading

faboweb commented Dec 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sabau Dec 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbibla commented Dec 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

faboweb commented Dec 17, 2018 • edited Loading

fedekunze commented Dec 17, 2018

fedekunze commented Dec 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

faboweb commented Dec 17, 2018

faboweb commented Dec 17, 2018

sabau commented Dec 18, 2018

sabau commented Dec 18, 2018

sabau commented Dec 12, 2018 •

edited

Loading

codecov bot commented Dec 13, 2018 •

edited

Loading

fedekunze commented Dec 13, 2018 •

edited

Loading

sabau Dec 14, 2018 •

edited

Loading

faboweb commented Dec 17, 2018 •

edited

Loading