Fabo/1379 remove errors in tests #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 3, 2019 11:35
Codecov Report
@@ Coverage Diff @@
## develop #1782 +/- ##
===========================================
- Coverage 95.07% 94.86% -0.21%
===========================================
Files 122 122
Lines 2982 2982
Branches 128 128
===========================================
- Hits 2835 2829 -6
- Misses 137 143 +6
Partials 10 10
|
Codecov Report
@@ Coverage Diff @@
## develop #1782 +/- ##
===========================================
- Coverage 95.07% 94.86% -0.21%
===========================================
Files 122 122
Lines 2982 2982
Branches 128 128
===========================================
- Hits 2835 2829 -6
- Misses 137 143 +6
Partials 10 10
|
fedekunze
reviewed
Jan 3, 2019
|
That's Unit testing 👍 |
sabau
reviewed
Jan 4, 2019
| await TmSessionSignIn.methods.onSubmit.call(self) | ||
| expect($store.commit).toHaveBeenCalledWith(`notifyError`, { | ||
| title: `Signing In Failed`, | ||
| body: expect.stringContaining(`Planned rejection`) |
There was a problem hiding this comment.
This looks weird at first sight, but it's actually nice
sabau
approved these changes
Jan 4, 2019
| @@ -69,16 +69,27 @@ describe(`TmSessionSignIn`, () => { | |||
| }) | |||
|
|
|||
| it(`should show a notification if signin failed`, async () => { | |||
| store.dispatch = jest.fn(() => Promise.reject(`Planned rejection`)) | |||
| wrapper.setData({ | |||
| let $store = { | |||
There was a problem hiding this comment.
Minor: let can be changed to const if we don't plan to reassign those variables, there are some of those along the PR
There was a problem hiding this comment.
let's just turn this on https://eslint.org/docs/rules/prefer-const
Closed
|
Will merge and we can switch the rule on after deciding so in Tuesdays meeting. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1379
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer