Fabo/1809 update header on send #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a9e29b2.
Co-Authored-By: faboweb <[email protected]>
|
Proposal submission works for me. But:
|
sabau
reviewed
Jan 18, 2019
sabau
reviewed
Jan 18, 2019
| const depositDenom = governanceParameters.deposit.min_deposit[0].denom | ||
|
|
||
| // TODO: refactor according to new unit test standard |
sabau
reviewed
Jan 18, 2019
sabau
reviewed
Jan 18, 2019
sabau
reviewed
Jan 18, 2019
|
Wow you were quicker than me to self-report those two 👍I left other minor stuff for the tests but once those problems on Send and Delegation are fixed I think we should merge. The object refactor may also be a separate PR right? |
faboweb
changed the title
added 2 commits
January 21, 2019 18:31
faboweb
changed the title
Signed-off-by: Karoly Albert Szabo <[email protected]>
fedekunze
reviewed
Jan 23, 2019
fedekunze
previously requested changes
Jan 23, 2019
|
Let's fix optimistic updates of proposal creation in another PR. |
jbibla
reviewed
Jan 24, 2019
| address() { | ||
| return this.user.address | ||
| }, | ||
| unbondedAtoms() { | ||
| return this.num.shortNumber(this.user.atoms) | ||
| return this.num.shortNumber(this.liquidAtoms) |
jbibla
reviewed
Jan 24, 2019
| state.balances.push({ denom: `coin`, amount: `42` }) | ||
|
|
||
| // add new | ||
| const balance = { denom: `leetcoin`, amount: `1337` } |
jbibla
approved these changes
Jan 24, 2019
fedekunze
reviewed
Jan 24, 2019
| @@ -1085,7 +1085,7 @@ Msg Traces: | |||
| return results | |||
| } | |||
|
|
|||
| let tally_result = { | |||
There was a problem hiding this comment.
this should have stayed the same since the final_tally_result update was only on the proposals not on the tally endpoint cc: @faboweb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1809
Based on Web PR
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer