Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/1831 reconnect #1856

Merged
merged 8 commits into from
Jan 22, 2019
Merged

Fabo/1831 reconnect #1856

merged 8 commits into from
Jan 22, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Jan 20, 2019

Closes #1831

Description:

❤️ Thank you!

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@faboweb faboweb changed the base branch from develop to web January 20, 2019 22:54
@faboweb faboweb changed the title [WIP] Fabo/1831 reconnect Fabo/1831 reconnect Jan 21, 2019
fedekunze
fedekunze previously approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

app/src/renderer/vuex/modules/connection.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #1856 into web will decrease coverage by 0.06%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##              web    #1856      +/-   ##
==========================================
- Coverage   93.56%   93.49%   -0.07%     
==========================================
  Files         116      115       -1     
  Lines        2517     2507      -10     
  Branches      116      116              
==========================================
- Hits         2355     2344      -11     
- Misses        153      154       +1     
  Partials        9        9
Impacted Files Coverage Δ
app/src/renderer/connectors/rpcWrapperMock.js 43.75% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/config.js 75% <ø> (-1.2%) ⬇️
app/src/renderer/App.vue 100% <ø> (ø) ⬆️
app/src/renderer/connectors/rpcWrapper.js 100% <100%> (ø) ⬆️
app/src/renderer/main.js 79.16% <100%> (-2.66%) ⬇️
app/src/renderer/vuex/modules/connection.js 92.59% <91.3%> (-3.57%) ⬇️

1 similar comment
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #1856 into web will decrease coverage by 0.06%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##              web    #1856      +/-   ##
==========================================
- Coverage   93.56%   93.49%   -0.07%     
==========================================
  Files         116      115       -1     
  Lines        2517     2507      -10     
  Branches      116      116              
==========================================
- Hits         2355     2344      -11     
- Misses        153      154       +1     
  Partials        9        9
Impacted Files Coverage Δ
app/src/renderer/connectors/rpcWrapperMock.js 43.75% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/config.js 75% <ø> (-1.2%) ⬇️
app/src/renderer/App.vue 100% <ø> (ø) ⬆️
app/src/renderer/connectors/rpcWrapper.js 100% <100%> (ø) ⬆️
app/src/renderer/main.js 79.16% <100%> (-2.66%) ⬇️
app/src/renderer/vuex/modules/connection.js 92.59% <91.3%> (-3.57%) ⬇️

@codecov
Copy link

codecov bot commented Jan 21, 2019 •
edited
Loading

Codecov Report

Merging #1856 into web will decrease coverage by 0.06%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##              web    #1856      +/-   ##
==========================================
- Coverage   93.56%   93.49%   -0.07%     
==========================================
  Files         116      115       -1     
  Lines        2517     2507      -10     
  Branches      116      116              
==========================================
- Hits         2355     2344      -11     
- Misses        153      154       +1     
  Partials        9        9
Impacted Files Coverage Δ
app/src/renderer/connectors/rpcWrapperMock.js 43.75% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/config.js 75% <ø> (-1.2%) ⬇️
app/src/renderer/App.vue 100% <ø> (ø) ⬆️
app/src/renderer/connectors/rpcWrapper.js 100% <100%> (ø) ⬆️
app/src/renderer/main.js 79.16% <100%> (-2.66%) ⬇️
app/src/renderer/vuex/modules/connection.js 92.59% <91.3%> (-3.57%) ⬇️

fedekunze
fedekunze approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze merged commit d86935d into web Jan 22, 2019
@fedekunze fedekunze deleted the fabo/1831-reconnect branch January 22, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jbibla jbibla Awaiting requested review from jbibla

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faboweb @fedekunze