Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jordan/1588 404 #1877

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Jordan/1588 404 #1877

merged 2 commits into from
Jan 24, 2019

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Jan 23, 2019

Closes #1588

Description:

  • updated stylez
  • added 404 to the page

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #1877 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1877      +/-   ##
===========================================
+ Coverage    94.97%   94.97%   +<.01%     
===========================================
  Files          125      125              
  Lines         2906     2908       +2     
  Branches       117      117              
===========================================
+ Hits          2760     2762       +2     
  Misses         135      135              
  Partials        11       11
Impacted Files Coverage Δ
app/src/renderer/components/common/Page404.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/wallet/PageWallet.vue 100% <ø> (ø) ⬆️
...src/renderer/components/common/PagePreferences.vue 100% <0%> (ø) ⬆️
app/src/renderer/components/common/ToolBar.vue 91.66% <0%> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #1877 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1877      +/-   ##
===========================================
+ Coverage    94.97%   94.97%   +<.01%     
===========================================
  Files          125      125              
  Lines         2906     2908       +2     
  Branches       117      117              
===========================================
+ Hits          2760     2762       +2     
  Misses         135      135              
  Partials        11       11
Impacted Files Coverage Δ
app/src/renderer/components/common/Page404.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/wallet/PageWallet.vue 100% <ø> (ø) ⬆️
...src/renderer/components/common/PagePreferences.vue 100% <0%> (ø) ⬆️
app/src/renderer/components/common/ToolBar.vue 91.66% <0%> (ø) ⬆️

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight to the point 👍 let's merge

@sabau sabau merged commit fcb0228 into develop Jan 24, 2019
@sabau sabau deleted the jordan/1588-404 branch January 24, 2019 09:29
@jbibla
Copy link
Collaborator Author

jbibla commented Jan 24, 2019

sorry this was to develop.

also, i took some liberties with the design 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page doesn't contain any not found message
2 participants