Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1896 correctly post process account request #1901

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Jan 29, 2019

Closes #1896

Description:

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #1901 into develop will increase coverage by 0.11%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1901      +/-   ##
===========================================
+ Coverage    94.52%   94.64%   +0.11%     
===========================================
  Files          118      118              
  Lines         2465     2463       -2     
  Branches       116      116              
===========================================
+ Hits          2330     2331       +1     
+ Misses         125      122       -3     
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/vuex/modules/wallet.js 98.24% <ø> (+4.8%) ⬆️
app/src/renderer/connectors/lcdClient.js 100% <100%> (ø) ⬆️
app/src/renderer/scripts/wallet.js 100% <0%> (ø) ⬆️
...src/renderer/components/common/TmSessionImport.vue 100% <0%> (ø) ⬆️

jbibla
jbibla previously approved these changes Jan 29, 2019
@faboweb faboweb merged commit 1ee03b2 into develop Jan 29, 2019
@faboweb faboweb deleted the fabo/1896-postprocess-account-req branch January 29, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cached balances are not overwritten by update if wallet empty
2 participants