Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/fixed signing issues with updated SDK #1903

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Jan 29, 2019

Closes #ISSUE

Description:

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #1903 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1903      +/-   ##
===========================================
- Coverage    94.52%   94.52%   -0.01%     
===========================================
  Files          118      118              
  Lines         2467     2465       -2     
  Branches       116      116              
===========================================
- Hits          2332     2330       -2     
  Misses         125      125              
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/scripts/wallet.js 100% <ø> (ø) ⬆️

@faboweb faboweb merged commit 726e7cf into develop Jan 29, 2019
@faboweb faboweb deleted the fabo/fix-signing branch January 29, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants