Jordan/1894 favicons

[jbibla]

Closes #1894

Description:

• added favicons for all browsers and devices

❤️ Thank you!

---

• Added entries in CHANGELOG.md with issue # and GitHub username
• Reviewed Files changed in the github PR explorer

[codecov]

Codecov Report

Merging #1923 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1923   +/-   ##
=======================================
  Coverage       95%     95%           
=======================================
  Files          119     119           
  Lines         2565    2565           
  Branches       120     120           
=======================================
  Hits          2437    2437           
  Misses         118     118           
  Partials        10      10

[jbibla]

unrelated to this PR: we should probably bundle this instead of making this request here? what do you guys think?

@sabau @faboweb @fedekunze

[sabau]

I think it's ok to keep it in the main template, those resources won't change often

Thanks for fixing the indentation here 👍

[jbibla]

i don't know how / if this was working before - but imgs wasn't an actual path

[sabau]

webpack was moving the files in the imgs folder and fixing the references where needed (css js or ejs files), but this renaming iswas confusing and does not add value at all 👍 good cleanup

[sabau]

[sabau]

I would put the images inside the assets folder, keeping them at root level seems a bit confusing -> and then changing all the references in the manifest and the links

[jbibla]

this was simpler because i didn't need to tell webpack to move the assets (there is an icon folder, separate from the assets folder) and because the paths didn't seem to work in index.ejs ... i also wanted the favicons to work locally.

if you can, would you mind taking a look to see if this is easy to accomplish?

[sabau]

I used the static vue folder, this morning I was curious why they suggested 2 assets in their structure suggestions, now I found out, usually I was using the webpack plugin to copy static stuff, but Vue apparently is doing this out of the box

[jbibla]

thanks for the help @sabau!!

[sabau]

Let's iconize Voyager