Jordan/1869 network page #1925
Merged
Jordan/1869 network page #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1925 +/- ##
===========================================
+ Coverage 95% 95.03% +0.02%
===========================================
Files 119 120 +1
Lines 2565 2576 +11
Branches 120 122 +2
===========================================
+ Hits 2437 2448 +11
Misses 118 118
Partials 10 10
|
|
I already like this codewise, once the coverage is happy we should merge it |
|
yep! i'll add some tests. |
jbibla
commented
Feb 4, 2019
fedekunze
reviewed
Feb 5, 2019
| @@ -80,7 +80,11 @@ export default [ | |||
| name: `transactions`, | |||
| component: require(`./components/wallet/PageTransactions`).default | |||
| }, | |||
|
|
|||
| { | |||
| path: `/network`, | |||
There was a problem hiding this comment.
This should be the default route
There was a problem hiding this comment.
interesting idea @fedekunze! i don't want to make this change right now, but we should talk about it at the next team meeting. i've added it to the agenda.
remember, eventually we will have a dashboard as the default route - but this might be a good interim solution.
Signed-off-by: Karoly Albert Szabo <[email protected]>
sabau
approved these changes
Feb 5, 2019
|
A screenshot of the page would have been nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1869
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer