Jordan/1866 blocks #1933
Jordan/1866 blocks #1933
Conversation
…o a router-link caused a lot of tests to fail because router-link wasn't stubbed
Codecov Report
@@ Coverage Diff @@
## develop #1933 +/- ##
===========================================
+ Coverage 95.1% 95.18% +0.08%
===========================================
Files 120 121 +1
Lines 2593 2618 +25
Branches 122 122
===========================================
+ Hits 2466 2492 +26
+ Misses 117 116 -1
Partials 10 10
|
| <td>{{ precommit.validator_address }}</td> | ||
| <td> | ||
| {{ | ||
| moment(precommit.timestamp).format( |
There was a problem hiding this comment.
same as up, would be nicer to have the formatting logic coded only once
…erties, updated snaps
| return moment(this.time).format(`MMM Do YYYY, HH:mm:ss`) | ||
| const time = moment(this.time) | ||
| return time.format( | ||
| `${moment().isSame(time, `day`) ? `` : `MMM Do YYYY `}HH:mm:ss` |
There was a problem hiding this comment.
is there a test for showing the result when it's not the same day?
There was a problem hiding this comment.
As for now nothing else than a snapshot that look only at the same day version, and not the other one.
We should add a tiny test on this, I'll push it here ok?
what if we move this into app/src/renderer/scripts/time.js (other PR maybe)
There was a problem hiding this comment.
Just added the test (I had to merge develop to have Date working)
| @@ -47,7 +47,10 @@ export default { | |||
| }, | |||
| computed: { | |||
| date() { | |||
| return moment(this.time).format(`MMM Do YYYY, HH:mm:ss`) | |||
| const time = moment(this.time) | |||
There was a problem hiding this comment.
If you move everything to this destructuring should you here also use date({ time } = this) {.
There was a problem hiding this comment.
- makes the test on this sweetier
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
closes #1744 - bringing explorer back to voyager
closes #1866 - added blocks to page network
closes #1867 - added block page
closes #1784 - removed links to external explorer
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer