Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jordan/1946 proposer address #1963

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Jordan/1946 proposer address #1963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe93bc7
remove proposer_address raw hex's
jbibla Feb 13, 2019
2111f59
cha cha cha changelog
jbibla Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- [\#1855](https://github.com/cosmos/voyager/issues/1855) skip gaia build if already built that hash @sabau
- [\#1922](https://github.com/cosmos/voyager/issues/1922) removed font awesome @jbibla
- [\#1948](https://github.com/cosmos/voyager/pull/1948) changed PR template @fedekunze
- [\#1946](https://github.com/cosmos/voyager/pull/1946) removed proposer_address raw hex @jbibla

### Fixed

Expand Down
40 changes: 0 additions & 40 deletions app/src/renderer/components/network/PageBlock.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@
<dt>Time</dt>
<dd>{{ blockTime }}</dd>
</dl>
<dl class="info_dl colored_dl">
<dt>Proposer</dt>
<dd>{{ block.block.header.proposer_address }}</dd>
</dl>
</div>
</div>

Expand All @@ -53,39 +49,6 @@
</div>
</div>
</div>

<div class="page-profile__section block">
<div class="row">
<div class="column">
<dl class="info_dl colored_dl">
<dt>Pre Commits</dt>
<dd v-if="!block.block.last_commit.precommits">No precommits</dd>
<table v-else class="pre-commits data-table">
<thead>
<panel-sort :properties="properties" />
</thead>
<tbody>
<tr
v-for="(precommit, index) in blockPrecommits"
:key="index"
class="block data-table__row"
>
<td>{{ precommit.validator_address }}</td>
<td>
{{
moment(precommit.timestamp).format(
"MMM Do YYYY, HH:mm:ss"
)
}}
</td>
<td>{{ precommit.round }}</td>
</tr>
</tbody>
</table>
</dl>
</div>
</div>
</div>
</template>
</tm-page>
</template>
Expand Down Expand Up @@ -132,9 +95,6 @@ export default {
},
blockTime({ moment, block } = this) {
return moment(block.block.header.time).format(`MMM Do YYYY, HH:mm:ss`)
},
blockPrecommits({ block } = this) {
return block.block.last_commit.precommits
}
},
watch: {
Expand Down
1 change: 0 additions & 1 deletion app/src/renderer/components/network/PageNetwork.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
>
</td>
<td>{{ block.header.num_txs }}</td>
<td>{{ block.header.proposer_address }}</td>
</tr>
</tbody>
</table>
Expand Down
62 changes: 0 additions & 62 deletions test/unit/specs/components/network/__snapshots__/PageBlock.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,6 @@ exports[`PageBlock has the expected html structure 1`] = `
Jan 1st 1970, 00:00:42
</dd>
</dl>

<dl
class="info_dl colored_dl"
>
<dt>
Proposer
</dt>

<dd>
ABCDEFG123456HIJKLMNOP
</dd>
</dl>
</div>
</div>

Expand Down Expand Up @@ -121,55 +109,5 @@ exports[`PageBlock has the expected html structure 1`] = `
</div>
</div>
</div>

<div
class="page-profile__section block"
>
<div
class="row"
>
<div
class="column"
>
<dl
class="info_dl colored_dl"
>
<dt>
Pre Commits
</dt>

<table
class="pre-commits data-table"
>
<thead>
<panel-sort-stub
properties="[object Object],[object Object],[object Object]"
/>
</thead>

<tbody>
<tr
class="block data-table__row"
>
<td>
validator address
</td>

<td>

Jan 1st 1970, 00:00:42

</td>

<td>
0
</td>
</tr>
</tbody>
</table>
</dl>
</div>
</div>
</div>
</tm-page-stub>
`;
8 changes: 0 additions & 8 deletions test/unit/specs/components/network/__snapshots__/PageNetwork.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,6 @@ exports[`PageNetwork has the expected html structure 1`] = `
<td>
1200
</td>

<td>
ABCDEFG123456HIJKLMNOP
</td>
</tr>
<tr
class="block data-table__row"
Expand All @@ -181,10 +177,6 @@ exports[`PageNetwork has the expected html structure 1`] = `
<td>
405
</td>

<td>
ZYXCRS123456HIJKLMNOPQ
</td>
</tr>
</tbody>
</table>
Expand Down