convert no-with-statement rule to use a walk function (microsoft#773)

lupine86 · Feb 26, 2019 · fa6a398 · fa6a398
1 parent 276999c
commit fa6a398
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/noWithStatementRule.ts b/src/noWithStatementRule.ts
@@ -22,15 +22,16 @@ export class Rule extends Lint.Rules.AbstractRule {
     public static FAILURE_STRING: string = 'Forbidden with statement';
 
     public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
-        return this.applyWithWalker(new NoWithStatementWalker(sourceFile, this.getOptions()));
+        return this.applyWithFunction(sourceFile, walk);
     }
 }
 
-class NoWithStatementWalker extends Lint.RuleWalker {
-    protected visitNode(node: ts.Node): void {
+function walk(ctx: Lint.WalkContext<void>) {
+    function cb(node: ts.Node): void {
         if (node.kind === ts.SyntaxKind.WithStatement) {
-            this.addFailureAt(node.getStart(), node.getWidth(), Rule.FAILURE_STRING);
+            ctx.addFailureAt(node.getStart(), node.getWidth(), Rule.FAILURE_STRING);
         }
-        super.visitNode(node);
     }
+
+    return ts.forEachChild(ctx.sourceFile, cb);
 }