Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres driver: Use struct in_addr #4

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Conversation

jubalh
Copy link
Contributor

@jubalh jubalh commented Feb 22, 2018

Since we later memcopy:

memcpy(&(sadr.sin_addr), (struct in_addr *) &iaddr, sizeof(iaddr));

it is a good idea to to use the in_addr struct instead of the ulong to
make it work among all platforms and architectures.

Apply openSUSE patch: unixODBC-iaddr.patch

Since we later memcopy:
```
memcpy(&(sadr.sin_addr), (struct in_addr *) &iaddr, sizeof(iaddr));
```

it is a good idea to to use the in_addr struct instead of the ulong to
make it work among all platforms and architectures.

Apply openSUSE patch: unixODBC-iaddr.patch
@lurcher
Copy link
Owner

lurcher commented Feb 22, 2018 via email

@jubalh
Copy link
Contributor Author

jubalh commented Feb 22, 2018

Yes even though it is not maintained and only an example I think it's good to have this. I saw several distributions building this driver.

I will make that change

Just pressing 'merge' will be enough :)

@lurcher lurcher merged commit 0ffca7d into lurcher:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants